fix(desktop): clicking the active session from a full page returns to the chat - #71901
Merged
Conversation
… the chat
While the workspace pane shows a full page (Artifacts, Skills, Messaging, a
plugin route), a sidebar click on the ACTIVE session did nothing: onResumeSession
took focusOpenSession's `true` for the main-session branch as "already on
screen" and skipped the navigate, but fronting the workspace tab doesn't put the
chat back — the page is still routed. The user had to click some other session
and then the active one to get back.
focusOpenSession now reports WHICH surface it fronted ('main' | 'tile' | null),
and focusedSessionNeedsRoute decides: a tile never needs a route (its pane
renders the chat regardless), a main hit does while a page covers the workspace.
OutThisLife
enabled auto-merge
July 26, 2026 10:27
alt-glitch
added
type/bug
Collaborator
Contributor
૮ >ﻌ< ა ci reviewran on ecf8ef9 ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence is publishing... |
Closed
13 tasks
This was referenced Jul 30, 2026
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…ick-active fix(desktop): clicking the active session from a full page returns to the chat
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
…ick-active fix(desktop): clicking the active session from a full page returns to the chat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the workspace pane is showing a full page — Artifacts, Skills, Messaging, or a plugin route — clicking the active session in the sidebar did nothing. You had to click some other session first and then the active one to get back to the chat.
onResumeSessiontreatedfocusOpenSession's boolean as "already on screen" and skipped the navigate. That's right for a session tile (its pane renders the chat on any route) but wrong for the main session: fronting the workspace tab doesn't unroute the page, so the click was a no-op.focusOpenSessionnow reports which surface it fronted ('main' | 'tile' | null) andfocusedSessionNeedsRoutemakes the call — a main hit still routes back while a page covers the workspace.