Render the workspace pane from its own session slice - #71836
Merged
Conversation
The workspace pane read the global $messages/$busy atoms — a mirror of whichever session was active — while every ⌘T tile rendered from its own $sessionStates slice. With two turns in flight, navigating away from a still-streaming session left it painting into the surface now showing a different conversation: the wrong transcript under the right route. Point the primary view at the active session's own slice, keeping the global atoms as the draft surface for a chat that has no runtime id yet.
Contributor
૮ >ﻌ< ა ci reviewran on c489480 ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
alt-glitch
added
type/bug
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…eground-leak Render the workspace pane from its own session slice
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
…eground-leak Render the workspace pane from its own session slice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking a finished session in the sidebar while another turn was still streaming showed the streaming session's output under the clicked session's route. The prompt routed correctly and nothing was corrupted on disk — the wrong transcript was simply painted.
Every ⌘T tile renders from its own
$sessionStates[runtimeId]slice. The workspace pane was the one surface that didn't: it read the global$messages/$busyatoms, which mirror whichever session is active. That mirror is fine with one turn at a time, but tabs made concurrent turns routine — so navigating away from a running session left it writing into the surface now showing a different conversation.The primary view now reads the active session's own slice, which makes the bleed structurally impossible rather than guarded. The global atoms stay the draft surface: a new chat has no runtime id, and therefore no slice, until its first turn creates one. "Main" becomes what it always should have been — the first tab, with no privileged state.
Verified by reverting the fix and re-running the new tests against main: 3 of 4 fail there, all 4 pass here.