fix(gateway): include .3gp in MEDIA_DELIVERY_EXTS - #71622
Closed
Slobaka wants to merge 1 commit into
Closed
Conversation
MEDIA_DELIVERY_EXTS is the shared allowlist for extract_media / extract_local_files / MEDIA: cleanup. It drifted from peer `_VIDEO_EXTS` sets and omitted .3gp, so MEDIA:/clip.3gp was not extracted and the tag was not stripped from message text.
alt-glitch
added
type/bug
4 tasks
Contributor
|
Closing — resolved on main via PR #72170, which cherry-picked #71683 by @Linux2010 (the earliest and widest submission: .3gp in MEDIA_DELIVERY_EXTS plus the .webm drift in send_message_tool and the Feishu adapter). Verified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.3gptoMEDIA_DELIVERY_EXTSvideo partition (parity with gateway_VIDEO_EXTS)MEDIA:/clip.3gpis not extracted and the tag is not stripped from textFixes #71621
Test plan
bash scripts/run_tests.sh tests/gateway/test_platform_base.py tests/gateway/test_extract_local_files.py -- -k '3gp or video_ext or MediaExtension or share_one_extension'