fix(tools): recognize discovered plugin platforms - #71582
Closed
tachyon-r wants to merge 1 commit into
Closed
Conversation
alt-glitch
added
type/bug
Contributor
|
Thanks for addressing a real CLI gap: current Problems
Suggested changes
Automated hermes-sweeper review. |
tachyon-r
force-pushed
the
tachyon/pr-plugin-platform-20260725
branch
from
July 30, 2026 12:04
5b6b481 to
3b6864b
Compare
teknium1
added
sweeper:risk-compatibility
tachyon-r
force-pushed
the
tachyon/pr-plugin-platform-20260725
branch
from
July 30, 2026 12:14
3b6864b to
3e76520
Compare
Contributor
Author
|
Follow-up verification on the current PR head ( |
teknium1
added a commit
that referenced
this pull request
Aug 15, 2026
…red() The salvaged registered_names() from PR #71582 predates the scoped platform registry: it read only the process-global _entries/_deferred maps, but plugin platforms register their deferred loaders under a profile scope. Result: `hermes tools enable a2a --platform a2a` still rejected the platform. Union the current-scope maps with the global ones, mirroring is_registered()'s semantics, under the registry lock.
Contributor
|
Heads-up: PR #86660 (#86660) cherry-picked your commit with authorship preserved — |
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
…red() The salvaged registered_names() from PR NousResearch#71582 predates the scoped platform registry: it read only the process-global _entries/_deferred maps, but plugin platforms register their deferred loaders under a profile scope. Result: `hermes tools enable a2a --platform a2a` still rejected the platform. Union the current-scope maps with the global ones, mirroring is_registered()'s semantics, under the registry lock.
bobaba76
pushed a commit
to bobaba76/hermes-agent
that referenced
this pull request
Aug 27, 2026
…red() The salvaged registered_names() from PR NousResearch#71582 predates the scoped platform registry: it read only the process-global _entries/_deferred maps, but plugin platforms register their deferred loaders under a profile scope. Result: `hermes tools enable a2a --platform a2a` still rejected the platform. Union the current-scope maps with the global ones, mirroring is_registered()'s semantics, under the registry lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
hermes toolsto recognize platforms discovered from installed plugins.Problem
Tool configuration validated
--platformonly against the built-in platform table. A correctly discovered plugin platform could therefore run in the gateway but failhermes tools list/enable/disable --platform <plugin>as an unknown platform.Fix
Resolve the accepted platform set from built-ins plus plugin discovery, while preserving current behavior when plugin loading fails.
Validation
scripts/run_tests.sh tests/hermes_cli/test_tools_disable_enable.pygit diff --checkpassed