fix(desktop): isolate hidden pane composer metrics - #71507
Closed
qdivan wants to merge 1 commit into
Closed
Conversation
Author
|
Closing as superseded by #71840, which has now merged a broader per-chat-surface fix for the same global measured-height race (including composer cleanup ownership). Thank you! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #71264.
Validation
origin/main:NODE_ENV=test npm run test:ui -- src/app/chat/composer/hooks/use-composer-metrics.test.tsx(2 expected failures: hidden measurement overwrote88pxwith32px; hidden unmount cleared the foreground value)NODE_ENV=test npm run test:ui -- src/app/chat/composer/hooks/use-composer-metrics.test.tsx(3 passed)NODE_ENV=test npm run test:ui -- src/components/pane-shell/pane-visibility.test.ts src/app/chat/composer/focus.test.ts src/app/chat/session-drag.test.ts src/app/chat/composer/hooks/use-composer-metrics.test.tsx(11 passed)npx eslint src/app/chat/composer/hooks/use-composer-metrics.ts src/app/chat/composer/hooks/use-composer-metrics.test.tsxnpm run typecheckgit diff --checkDuplicate Check
Checked live on 2026-07-26 against
origin/mainat07e97d2f5dc3d2092cfe693ef07b2527a36cd2d8. Issue #71264 remains open with no linked PR or comments. Searches by issue number,useComposerMetrics,composer-measured-height, and hidden-pane metrics found no equivalent active or merged fix. PR #39564 addresses separate scrolling/stacked-layout behavior and does not modify the shared metric hook or hidden-pane ownership.Browser / Playwright
Not run: this is a Desktop/Electron issue reported on Windows 11, while the validation environment is Linux. The component regression uses the production
data-pane-hiddenmarker and directly exercises the document-root CSS variables that control thread bottom clearance. A Windows 11 Desktop smoke test remains useful for final pixel-level confirmation.