fix(cron): avoid provider summaries for script jobs - #71494
Closed
yinkev wants to merge 1 commit into
Closed
Conversation
Collaborator
13 tasks
Contributor
Author
|
Closing in favor of the earlier #70977 after validating its patch on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no_agent=Truecron jobs;Fixes #70908.
Root cause
The failure summarizer scanned the complete script stdout for bare
401,403,429, quota, and timeout text without considering execution mode. A script-only job can print those strings in successful checks, then fail for an unrelated reason. Sinceno_agentjobs never call a model provider, every provider classification on that path is structurally wrong.Verification
mainfor authentication, quota, and timeout text;no_agentcron suite: 22 passed;py_compile, andgit diff --check: clean.