fix(run-agent): rotate credential pool on billing-classified 400s - #7112
Merged
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #6940 by @helix4u — cherry-picked onto current main.
Bridges a gap where
classify_api_error()correctly identifies billing-style HTTP 400 errors (e.g. Anthropic "out of extra usage") and setsshould_rotate_credential=Truewithreason=FailoverReason.billing, but_recover_with_credential_pool()only checked raw status codes (401/402/429) and ignored the classified reason.Changes
_recover_with_credential_pool()accepts optionalclassified_reasonparameterclassified.reasonfrom the error classifierTest results
recover_with_pooltests: 7 passedtest_credential_pool_routing.py: 14 passed