fix(kanban): add kind='transient' to goal loop blocks to enable auto recovery (#71050) - #71071
Closed
webtecnica wants to merge 2 commits into
Closed
fix(kanban): add kind='transient' to goal loop blocks to enable auto recovery (#71050)#71071webtecnica wants to merge 2 commits into
webtecnica wants to merge 2 commits into
Conversation
Contributor
|
Thanks for the focused #71050 implementation. I preserved your core commit and authorship in #71088, rebased it directly onto current |
Contributor
Author
|
Closing as superseded — your #71088 preserves authorship and adds the missing regression coverage. Appreciated! 🙌 |
Contributor
Author
|
Closed by author — superseded by #71088. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #71050 — the kanban goal loop's
_block()closure and both goal-loop exit paths were callingblock_task()withoutkind=, producing untyped blocks that no automated recovery path can safely act on.Changes
cli.py(the_blockclosure, ~L16090)kind: str | None = Noneparameter_kb.block_task(c, task_id, reason=reason, kind=kind)hermes_cli/goals.py(two call sites)kanban_completeafter finalize nudge): addedkind="transient"N/Nwithout completing): addedkind="transient"Both exits are machine-emitted lifecycle noise the worker couldn't resolve —
transientis the correct kind because it marks the block as retryable, recoverable lifecycle noise.tests/hermes_cli/test_kanban_goal_mode.py_block()to accept optionalkind=Noneparameter so the existing test passes with the new call signature.Impact
Cards blocked by the goal loop now carry
kind="transient", making them visible to automated recovery paths that watch for recoverable blocks instead of being stranded as untyped blocks indistinguishable from a human hold.