fix(telegram+tools): prevent connect hang with retry watchdog and fresh app per attempt (#67498, #68915) - #70884
Merged
kshitijk4poor merged 3 commits intoJul 24, 2026
Conversation
…ker deadlock on server backgrounding Issue NousResearch#68915: when the agent runs a compound command with trailing & (e.g. `cd /app && node server.js &`), bash parses it as `(A && B) &` — a subshell that holds the stdout pipe open forever when B is a long-running server. The existing _rewrite_compound_background in terminal_tool.py correctly rewrites this to `A && { B & }` to avoid the subshell fork, but it was only applied in the foreground execute() path (tools/environments/base.py). The background spawn_local() path bypasses base.py entirely and passed the raw command directly to Popen/PTY, leaving the deadlock unmitigated. Fix: apply _rewrite_compound_background in spawn_local() before the command is passed to Popen or PTY spawn. Uses a lazy import to avoid circular dependency (terminal_tool imports process_registry). - PTY spawn path: now uses safe_command (rewritten) - Popen spawn path: now uses safe_command (rewritten) - Session.command still stores the original (unrewritten) command for display - Simple `cmd &` is left unchanged (no subshell bug) Tests: 4 regression tests verifying (1) compound is rewritten, (2) simple bg is preserved, (3) multi-line compounds are rewritten, (4) session.command stores original.
… per attempt (NousResearch#67498) The Telegram adapter's connect retry loop could silently stall after 'Connecting to Telegram (attempt 1/8)...' with the event loop permanently parked in select() — all threads idle, no attempt 2/8 ever scheduled. Root cause analysis: - The retry loop reused the same Application object across all 8 attempts. After a failed initialize() the app could be in a partially- initialized state (closed httpx transports from , or flag set before the hang) causing subsequent calls to silently skip real initialization. - CancelledError (a BaseException, not an Exception) propagated silently through all except handlers with no logging — the task driving the retry loop could exit without any trace. - No total watchdog bound existed for the entire retry loop; only per-attempt timeouts via _await_with_thread_deadline. If the loop itself stalled between attempts (between-attempt sleep, cleanup, or scheduling), there was no timeout to catch it. Fixes: 1. **Total watchdog deadline**: Compute a total deadline for the entire connect loop (8 attempts × init_timeout + 120s margin). Before each attempt, check the wall clock; if exceeded, raise OSError immediately instead of attempting another initialize(). 2. **Fresh Application per retry**: On each failed attempt, rebuild via and re-register all handlers. The old app is best-effort shutdown with . This ensures each retry starts with a clean slate — no stale transports, no stale flag, no leaked state from the previous attempt. 3. **BaseException logging + propagation**: Added (placed LAST after all other handlers) to log CancelledError and other non-Exception signals before propagating. Previously these exited the retry loop silently with no log message. 4. ** block for app rebuild**: The clause runs after every failed attempt that isn't the last, rebuilding the app and discarding the old one regardless of which exception class caused the failure.
kshitijk4poor
enabled auto-merge (rebase)
July 24, 2026 17:31
This was referenced Jul 24, 2026
Closed
alt-glitch
added
type/bug
This was referenced Aug 3, 2026
Closed
kshitijk4poor
deleted the
salvage/70546-telegram-connect-hang-and-spawn-rewrite
branch
August 5, 2026 07:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs: Telegram gateway connect hang (#67498) and spawn_local compound-background deadlock (#68915).
Changes
plugins/platforms/telegram/adapter.py: total watchdog deadline for the connect retry loop, fresh Application rebuild per failed attempt, BaseException logging for CancelledErrortools/process_registry.py: apply_rewrite_compound_background()inspawn_local()to preventA && B &subshell deadlockstests/tools/test_process_registry.py: 4 new tests for compound-background rewrite in spawn_localcontributors/emails/agent@hermes.dev: contributor email mapping (commits authored by agent identity, PR by @webtecnica)Salvage of #70546 by @webtecnica — cherry-picked with authorship preserved.
Notes
_register_handlers()method), not blocking._shutdown_abandoned_appcall in the finally block is already best-effort (catches all exceptions internally). Thespawn_via_envpath correctly passesrewrite_compound_background=Falsesince it wraps commands in its own nohup structure.Validation
A && { B & }