fix(desktop): show pending cron trigger feedback - #70833
Closed
nv-cho wants to merge 1 commit into
Closed
Conversation
Block duplicate manual triggers before React rerenders. Keep the action busy and show a queued run until run history catches up.
nv-cho
force-pushed
the
fix/desktop-cron-trigger-feedback
branch
from
July 24, 2026 15:59
55cb2f9 to
d204ada
Compare
nv-cho
marked this pull request as ready for review
July 24, 2026 16:00
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-busywhile the trigger is pendingThe trigger handler relied on React state to block repeated activation, leaving a same-render window where two requests could start. Run History could only show persisted sessions, so an accepted trigger appeared missing until the backend created its session.
Fixes #70826
Test plan
npm run buildnpm run typechecknpx eslint src/app/cron/index.tsx src/app/cron/index.test.tsx src/app/overlays/panel.tsx src/app/overlays/panel.test.tsxnpx vitest run src/app/cron/index.test.tsx src/app/overlays/panel.test.tsx— 7 passednpm test -- --run— 2,754 passed; 3 skipped