feat(skills): add pinecone-research optional skill + trim pinecone description (salvage #46519) - #70512
Merged
Merged
Conversation
…pts + tests - Rename research/pinecone to pinecone-research (distinct from mlops/pinecone) - Shorten mlops/pinecone description to <=60 chars - Add rag_pipeline.py and memory_manager.py scripts - Add test_pinecone_research_skill.py (10 tests: frontmatter, scripts, naming) - Remove unconditional description: prefix strip from extract_skill_description()
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvages PR #46519 by @immuhammadfurqan onto current main: adds the
pinecone-researchoptional skill (agent RAG + long-term memory patterns with Pinecone, with helper scripts and smoke tests) and trims the over-limitmlops/pineconedescription (305 → 49 chars).The original PR was reworked by the author to address all three sweeper review asks (drop the stale
skill_utils.pyprefix-strip, rename the skill topinecone-research, add tests) but never got CI dispatched. Cherry-picked here with authorship preserved; follow-up commit adds the trailing periods the authoring standard requires.Changes
optional-skills/research/pinecone-research/: new skill — SKILL.md +scripts/rag_pipeline.py+scripts/memory_manager.pyoptional-skills/mlops/pinecone/SKILL.md: description 305 → 49 charstests/skills/test_pinecone_research_skill.py: 10 smoke testscontributors/emails/: mapping for @immuhammadfurqanValidation
scripts/run_tests.sh tests/skills/test_pinecone_research_skill.pyCredit: @immuhammadfurqan (commit authorship preserved via cherry-pick + rebase merge).
Infographic