Skip to content

feat(skills): add pinecone-research optional skill + trim pinecone description (salvage #46519) - #70512

Merged
teknium1 merged 3 commits into
mainfrom
salvage/46519-pinecone-descriptions
Jul 24, 2026
Merged

feat(skills): add pinecone-research optional skill + trim pinecone description (salvage #46519)#70512
teknium1 merged 3 commits into
mainfrom
salvage/46519-pinecone-descriptions

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Salvages PR #46519 by @immuhammadfurqan onto current main: adds the pinecone-research optional skill (agent RAG + long-term memory patterns with Pinecone, with helper scripts and smoke tests) and trims the over-limit mlops/pinecone description (305 → 49 chars).

The original PR was reworked by the author to address all three sweeper review asks (drop the stale skill_utils.py prefix-strip, rename the skill to pinecone-research, add tests) but never got CI dispatched. Cherry-picked here with authorship preserved; follow-up commit adds the trailing periods the authoring standard requires.

Changes

  • optional-skills/research/pinecone-research/: new skill — SKILL.md + scripts/rag_pipeline.py + scripts/memory_manager.py
  • optional-skills/mlops/pinecone/SKILL.md: description 305 → 49 chars
  • tests/skills/test_pinecone_research_skill.py: 10 smoke tests
  • contributors/emails/: mapping for @immuhammadfurqan

Validation

Result
scripts/run_tests.sh tests/skills/test_pinecone_research_skill.py 10/10 passed
Both descriptions ≤60 chars, end with period
Base current origin/main, diff shows only salvaged files

Credit: @immuhammadfurqan (commit authorship preserved via cherry-pick + rebase merge).

Infographic

pinecone-research

immuhammadfurqan and others added 3 commits July 23, 2026 20:14
…pts + tests

- Rename research/pinecone to pinecone-research (distinct from mlops/pinecone)
- Shorten mlops/pinecone description to <=60 chars
- Add rag_pipeline.py and memory_manager.py scripts
- Add test_pinecone_research_skill.py (10 tests: frontmatter, scripts, naming)
- Remove unconditional description: prefix strip from extract_skill_description()
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on 1a4e21b

❌ Job failures

Desktop E2E / Playwright E2E (Linux) · View job

Job Desktop E2E / Playwright E2E (Linux) failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants