Skip to content

docs(xai): x_search vs xurl routing on gated surfaces (salvage #29423) - #70510

Merged
teknium1 merged 2 commits into
mainfrom
hermes/hermes-c4ea22d7
Jul 24, 2026
Merged

docs(xai): x_search vs xurl routing on gated surfaces (salvage #29423)#70510
teknium1 merged 2 commits into
mainfrom
hermes/hermes-c4ea22d7

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Salvages @Julientalbot's x_search / xurl routing guidance (PR #29423) onto current main, with the skill-side half redesigned so the xurl SKILL stays self-contained.

The contributor's insight is right — agents holding both X surfaces need routing doctrine — but the original put an explicit x_search block inside the xurl skill, which loads even when x_search isn't registered (check_fn-gated on xAI credentials). Per the cross-toolset reference rule, the routing comparison now lives only on surfaces where both are known to exist together; the skill describes its search distinctively in its own terms (already landed in #70443).

Changes

  • Cherry-picked c3ad355 (@Julientalbot) — kept:
    • tools/x_search_tool.py: schema states read-only scope generically (no tool names)
    • toolsets.py + hermes_cli/tools_config.py: toolset description + setup note point authenticated work at the xurl skill (setup surfaces, both names legitimate)
    • website/docs (tools-reference, toolsets-reference, x-search feature page): x_search vs xurl comparison table + mixed-workflow guidance
  • Follow-up commit (ours):
    • Removed the x_search routing block + workflow step from the xurl SKILL; replaced with skill-native wording carrying the contributor's write-evidence rule ("only xurl output / X API response proves a state-changing action")
    • Rewrote tests/skills/test_xurl_x_search_routing.py to pin the placement contract — including that the skill never names credential-gated surfaces
    • Skill version 1.1.2 → 1.1.3

Validation

Check Result
tests/skills/test_xurl_x_search_routing.py + test_xurl_article_ingestion_docs.py pass
tests/tools/test_x_search_tool.py, tests/test_toolsets.py pass
tests/hermes_cli/test_tools_config.py pass

Infographic

x-search-routing

julientalbot-ergonomia and others added 2 commits July 23, 2026 20:12
Make the x_search / xurl boundary explicit in the skill, feature docs,
toolset metadata, setup note, and reference pages, while keeping the
model-facing x_search schema generic (no static xurl name).

Regression tests assert behavioral routing invariants rather than frozen
prose snapshots. Drop the stale CI-only plugin/hangup hunks already on
main so this rebases cleanly.
… gated surfaces

Follow-up on the salvaged commit: the xurl skill loads even when x_search
isn't registered (check_fn-gated on xAI credentials), so per the
cross-toolset reference rule the skill must not name it. Replaced the
skill's x_search routing block and workflow step with skill-native
wording (raw engageable posts, authenticated context, write-evidence
rule). The cross-surface comparison stays on surfaces where both are
known to exist: x-search feature docs, toolset description, tools-config
setup note, and the x_search tool schema (kept generic, no tool names).
Rewrote the routing tests to pin the placement contract, including that
the skill never names credential-gated surfaces.
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on 8fec41b

❌ Job failures

Desktop E2E / Playwright E2E (Linux) · View job

Job Desktop E2E / Playwright E2E (Linux) failed.

@alt-glitch alt-glitch added type/docs Documentation improvements P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard comp/tools Tool registry, model_tools, toolsets tool/skills Skills system (list, view, manage) provider/xai xAI (Grok) needs-decision Awaiting maintainer decision before any implementation labels Jul 24, 2026
@teknium1
teknium1 merged commit 6441b05 into main Jul 24, 2026
39 of 42 checks passed
@teknium1
teknium1 deleted the hermes/hermes-c4ea22d7 branch July 24, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/tools Tool registry, model_tools, toolsets needs-decision Awaiting maintainer decision before any implementation P3 Low — cosmetic, nice to have provider/xai xAI (Grok) tool/skills Skills system (list, view, manage) type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants