feat(desktop): add Russian (ru) UI locale - #70499
Open
Gromakoff wants to merge 2 commits into
Open
Conversation
Add a full Russian translation (ru.ts, ~2.8k keys) and wire it into the i18n catalog so it appears in the language picker. - i18n/ru.ts: new locale (common, settings, chat, composer, tools, ...). - i18n/languages.ts: register 'ru' language + locale aliases (ru-ru, ru_ru). - i18n/catalog.ts: import and include ru in the bundled locale set. - i18n/types.ts: declare the ru translation type. Type-checked against tsconfig.json (no i18n errors). Language is opt-in from the settings language picker; default locale unchanged.
alt-glitch
added
type/feature
Collaborator
…ier on ru locale Apply auto-fix for import ordering (catalog.ts, ru.ts) and remove unused FIELD_DESCRIPTIONS/FIELD_LABELS imports; run prettier --write. No behavioral change — purely formatting/lint compliance for CI.
teknium1
reviewed
Jul 30, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for contributing the Russian Desktop locale wiring.
Problems
- The branch is now conflicting. Its locale registry omits Arabic (
apps/desktop/src/i18n/catalog.ts:1-14on the PR), while current main imports and registers it atapps/desktop/src/i18n/catalog.ts:1,13, with matching entries inlanguages.ts:32-82andtypes.ts:8. A salvage must preserve that current-main surface. - The new catalog still renders English in several Russian overrides:
ru.ts:41,ru.ts:56,ru.ts:62,ru.ts:94, andru.ts:114. - No tests were added for the new aliases or persistence path. Existing locale behavior is covered in
apps/desktop/src/i18n/languages.test.ts:6-46; the Russian registration should receive equivalent behavior coverage.
Suggested changes
- Reconcile the locale registry against current main, retaining Arabic and current i18n fields.
- Translate or omit the explicit English Russian overrides, then add alias and config-persistence tests for
ru,ru-RU, andru_ru.
Automated hermes-sweeper review.
| zh, | ||
| 'zh-hant': zhHant, | ||
| ja, | ||
| ru |
Contributor
There was a problem hiding this comment.
Current main now also registers Arabic in this record (catalog.ts:1,13). This old-base replacement omits it, so a salvage must retain ar alongside ru rather than replacing the current locale set.
| set: 'Установить', | ||
| skip: 'Пропустить', | ||
| update: 'Обновить', | ||
| tryHint: term => `Try \u201C${term}\u201D`, |
Contributor
There was a problem hiding this comment.
This is a visible Russian-locale override but remains English. Please translate it (and audit the other explicit English overrides) or omit it so the documented defineLocale() English fallback is used intentionally.
| ja: 'ja', | ||
| 'ja-jp': 'ja', | ||
| ja_jp: 'ja', | ||
| ru: 'ru', |
Contributor
There was a problem hiding this comment.
Please add behavior coverage for ru, ru-RU, and ru_ru, including normalization, exact locale recognition, and persisted config values, following languages.test.ts.
teknium1
added
sweeper:risk-compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a complete Russian translation for the Hermes Desktop UI and wire it into the i18n catalog so it shows up in the language picker.
i18n/ru.ts: new locale (~2.8k keys: common, settings, chat, composer, tools, ...).i18n/languages.ts: register therulanguage + locale aliases (ru-ru,ru_ru).i18n/catalog.ts: import and includeruin the bundled locale set.i18n/types.ts: declare therutranslation type.Test plan
apps/desktop/tsconfig.json— no i18n type errors.Notes
Pure additive i18n change — no core/agent logic touched, no tool schemas or prompt-caching affected.
🤖 Generated with Hermes Agent