Skip to content

feat(skills): simplify-code v1.1.0 — altitude reviewer, inline fallback, upstream /simplify parity - #70440

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-33fd2a15
Jul 24, 2026
Merged

feat(skills): simplify-code v1.1.0 — altitude reviewer, inline fallback, upstream /simplify parity#70440
teknium1 merged 1 commit into
mainfrom
hermes/hermes-33fd2a15

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Updates the bundled simplify-code skill (v1.0.0 → v1.1.0) to track how Claude Code's /simplify evolved since our February-era port — most importantly adding the fourth Altitude reviewer and an inline no-delegation fallback. All prose is our own wording, concept-inspired from public changelog/docs descriptions, not copied.

Upstream timeline that motivated this (from the public Claude Code changelog):

  • v2.1.63 (Feb 2026): /simplify added — 3 parallel agents (reuse, quality, efficiency). This is what we ported.
  • v2.1.147 (May 21): renamed to /code-review, became a correctness bug-hunter; cleanup behavior removed.
  • v2.1.154 (May 28): /simplify restored as cleanup-only after community pushback ([FEATURE] Bring back /simplify anthropics/claude-code#61581), now with 4 angles: reuse, simplification, efficiency, altitude.
  • v2.1.213 (Jul): gained an inline single-pass fallback when agent fan-out is unavailable.

Changes

  • skills/software-development/simplify-code/SKILL.md:
    • New Reviewer 4 — Altitude: flags changes implemented at the wrong depth — special cases layered on shared code paths, symptom patches that leave sibling call sites broken, workaround-on-workaround stacks — and asks for the deeper mechanism fix. Includes a counter-caveat (compat shims / staged migrations / vendored-code isolation are deliberate, not band-aids). This dovetails with our AGENTS.md "fix the class, not the site" rubric.
    • Cleanup-vs-bug-hunt boundary stated up front: this skill polishes working code; correctness review belongs to requesting-code-review. New pitfall guards against drift.
    • Inline single-pass fallback: when delegate_task isn't available (leaf subagent, delegation disabled, budget exhausted), run all four angles sequentially in-context and disclose that in the summary — previously the skill had no answer for this and simply broke.
    • Concrete-cost field added to the finding format (what is duplicated/wasted/harder to maintain) — findings that can't articulate a cost are nits.
    • Efficiency reviewer gains closure-capture scope retention (long-lived callbacks keeping the whole enclosing scope alive) and the quality reviewer gains deep-nesting flattening.
    • Pitfalls updated: fan-out cap 3 → 4; altitude findings default to RISKY/flag-only inside a cleanup pass.
    • Kept our value-adds upstream doesn't have: SAFE/CAREFUL/RISKY risk tiers, Chesterton's-Fence-via-git-blame, dry-run/focus/scope modifiers, conflict-resolution order.
  • website/docs/user-guide/skills/bundled/software-development/software-development-simplify-code.md: regenerated via website/scripts/generate-skill-docs.py.
  • website/docs/reference/skills-catalog.md: description row updated (3-agent → 4-agent).

IP note

The updated prompts were written fresh in our own words from the concepts described in Anthropic's public changelog and community reports. Verified zero 8-word-shingle overlap against the upstream prompt texts.

Validation

Check Result
scripts/run_tests.sh tests/skills/ -q pass
Frontmatter (desc ≤ 60 chars, version, related_skills) pass
E2E: tools.skills_sync.sync_skills() into temp HERMES_HOME synced copy contains altitude reviewer, inline fallback, boundary line
Docs regen matches SKILL.md pass
Verbatim-overlap scan vs upstream prompt texts (8-word shingles) 0 matches

Infographic

simplify-code v1.1.0 quest update

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) labels Jul 24, 2026
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on d9a2acb

❌ Job failures

Desktop E2E / Playwright E2E (Linux) · View job

Job Desktop E2E / Playwright E2E (Linux) failed.

…ion (4th altitude reviewer, inline fallback)

Claude Code's /simplify was renamed away, community-restored, and rebuilt
since our 3-agent port (v2.1.63 -> v2.1.154+). This brings simplify-code
in line with the current upstream design, re-expressed in our own wording
and layered onto our existing risk-tier/confidence machinery:

- New Reviewer 4 (Altitude): flags band-aid fixes layered on shared
  infrastructure — special cases, symptom patches with unfixed sibling
  sites, workaround stacks — and points at the deeper mechanism fix.
  Matches our AGENTS.md 'fix the class, not the site' rubric.
- Explicit cleanup-vs-bug-hunt boundary: this skill improves working
  code; correctness review stays with requesting-code-review.
- Inline single-pass fallback when delegate_task is unavailable (leaf
  subagents, delegation disabled) — previously the skill just broke;
  now all four angles run sequentially with honest disclosure.
- Finding format gains a concrete-cost field.
- Efficiency reviewer adds closure-capture scope-retention leaks.
- Pitfalls: fan-out cap 3 -> 4, band-aid-vs-deliberate-boundary caveat,
  no-bug-hunting drift guard.

Kept our value-adds upstream lacks: SAFE/CAREFUL/RISKY tiers,
Chesterton's Fence via git blame, dry-run/focus/scope modifiers.
@teknium1
teknium1 force-pushed the hermes/hermes-33fd2a15 branch from cbd515c to d9a2acb Compare July 24, 2026 02:47
@teknium1
teknium1 merged commit 3910ab2 into main Jul 24, 2026
62 of 66 checks passed
@teknium1
teknium1 deleted the hermes/hermes-33fd2a15 branch July 24, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants