fix(security): scrub credentials from voice playback subprocesses - #70357
Closed
zapabob wants to merge 1 commit into
Closed
fix(security): scrub credentials from voice playback subprocesses#70357zapabob wants to merge 1 commit into
zapabob wants to merge 1 commit into
Conversation
## Summary - Spawn system audio players (`ffplay` / `afplay` / `aplay`) with `hermes_subprocess_env(inherit_credentials=False)`. - Prevent gateway tokens and provider API keys from leaking into OS media helpers. - Add a regression test asserting scrubbed env on `Popen`. ## Salvage / credit Sibling of NousResearch#70342 / incomplete NousResearch#56332 (TTS/STT command scrub) on the voice-mode playback path.
alt-glitch
added
type/security
2 tasks
Contributor
|
Merged into main via consolidated salvage PR #73514 (merge Your contribution is credited to you in git history. Thank you! Closing this PR as merged-via-salvage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ffplay/afplay/aplay) withhermes_subprocess_env(inherit_credentials=False).Popen.Salvage / credit
Sibling of #70342 / incomplete #56332 (TTS/STT command scrub) on the voice-mode playback path.
Test plan
pytest tests/tools/test_voice_mode_playback_env_scrub.py -q