Add configurable WhatsApp inbound read receipts - #70340
Closed
maff-t2b wants to merge 2 commits into
Closed
Conversation
alt-glitch
added
type/feature
Collaborator
Duplicate of #8690: this implements the same Baileys inbound readMessages mechanism for WhatsApp read receipts. The opt-in configuration is a scope variant within the existing read-receipt cluster. |
This was referenced Jul 28, 2026
kshitijk4poor
added a commit
that referenced
this pull request
Jul 28, 2026
Needed for PR #70340 attribution check.
kshitijk4poor
added a commit
that referenced
this pull request
Jul 28, 2026
- Change await self._send_read_receipt to asyncio.create_task to avoid blocking message dispatch on slow bridge responses (matches BlueBubbles pattern). Up to 5s per-message latency eliminated. - Update tests: assert_called_once_with instead of assert_awaited_once_with since the receipt is now scheduled, not directly awaited. - Add send_read_receipts documentation to whatsapp.md following the BlueBubbles docs pattern.
Collaborator
|
Merged via #73322 — your commits cherry-picked with authorship preserved (rebase-merge). Your implementation was the strongest of 4 competing PRs for this feature. We made three follow-up changes on top:
Thanks for the clean implementation! |
This was referenced Jul 28, 2026
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
Needed for PR NousResearch#70340 attribution check.
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…age) - Change await self._send_read_receipt to asyncio.create_task to avoid blocking message dispatch on slow bridge responses (matches BlueBubbles pattern). Up to 5s per-message latency eliminated. - Update tests: assert_called_once_with instead of assert_awaited_once_with since the receipt is now scheduled, not directly awaited. - Add send_read_receipts documentation to whatsapp.md following the BlueBubbles docs pattern.
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
Needed for PR NousResearch#70340 attribution check.
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
…age) - Change await self._send_read_receipt to asyncio.create_task to avoid blocking message dispatch on slow bridge responses (matches BlueBubbles pattern). Up to 5s per-message latency eliminated. - Update tests: assert_called_once_with instead of assert_awaited_once_with since the receipt is now scheduled, not directly awaited. - Add send_read_receipts documentation to whatsapp.md following the BlueBubbles docs pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_read_receiptsWhatsApp config settingTest plan
pytest -q -o addopts= tests/gateway/test_whatsapp_connect.py tests/gateway/test_whatsapp_reply_prefix.py tests/gateway/test_whatsapp_stale_bridge.py(54 passed)node --test scripts/whatsapp-bridge/bridge.native.test.mjs(passed)git diff --checkpassed