Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions tests/test_tui_gateway_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -9594,6 +9594,51 @@ def test_respond_unpacks_sid_tuple_correctly():
server._answers.pop("rid-x", None)


def test_approval_respond_forwards_reason_and_optional_resolve_all():
server._sessions["sid"] = _session()
try:
with patch(
"tools.approval.resolve_gateway_approval", return_value=1
) as mock_resolve:
response = server.handle_request(
{
"id": "1",
"method": "approval.respond",
"params": {
"session_id": "sid",
"choice": "deny",
"reason": "Denied for this exact reason.",
"all": True,
},
}
)

assert response["result"] == {"resolved": 1}
mock_resolve.assert_called_once_with(
"session-key",
"deny",
reason="Denied for this exact reason.",
resolve_all=True,
)

mock_resolve.reset_mock()
server.handle_request(
{
"id": "2",
"method": "approval.respond",
"params": {"session_id": "sid", "choice": "deny"},
}
)
mock_resolve.assert_called_once_with(
"session-key",
"deny",
reason=None,
resolve_all=False,
)
finally:
server._sessions.pop("sid", None)


# ---------------------------------------------------------------------------
# /model switch and other agent-mutating commands must reject while the
# session is running. agent.switch_model() mutates self.model, self.provider,
Expand Down
1 change: 1 addition & 0 deletions tui_gateway/methods_prompt.py
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,7 @@ def _(rid, params: dict) -> dict:
"resolved": resolve_gateway_approval(
session["session_key"],
params.get("choice", "deny"),
reason=params.get("reason"),
resolve_all=params.get("all", False),
)
},
Expand Down