fix(desktop): refresh externally written sessions - #70183
Conversation
GottZ
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Summary
Two PRs address external Desktop session updates, but at different layers: #37766 refreshes the selected transcript and messaging list, while #70183 reconciles the general bounded sidebar session list for sessions created by other local Hermes surfaces.
Related pull requests
- #37766 [closed]
related— (+415/-0) — keep closed as implemented on main: it adds guarded active-transcript read repair, revision checks, and busy-state race protection; contributor verification confirms the equivalent, including profile-aware reads and visibility refresh, was merged in #57636. - #70183
related— (+36/-2) — merge: it adds a non-overlapping five-second visible poll of refreshSessions, specifically covering externally created local CLI/TUI/phone-companion sessions that the already-merged active messaging-session refresh does not reconcile into the general sidebar list.
Suggested consolidation
Merge #70183 because its diff closes the remaining general sidebar-list gap and complements rather than duplicates the active messaging transcript implementation already merged via #57636. Keep #37766 closed as superseded by that merged implementation; no additional duplicate PR needs closing.
Cross-PR triage: Reviewed 2 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 17 kB of PR diffs, 2 kB of issue/PR text, 2 kB of discussion (3 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.
|
Thanks for addressing the externally-written session-list gap. This is an automated hermes-sweeper review; current
|
What changed
Hermes Desktop now reconciles the bounded local session list every five seconds while visible. The reconciliation is guarded against overlapping requests and retains the existing last-known list on transient failures.
Why
Sessions written by another local Hermes surface, such as the CLI, TUI, or a phone companion, update the authoritative state.db but do not emit on the current Desktop renderer websocket. The sidebar therefore remained stale until Desktop restarted.
Impact
Externally-created local sessions appear in the normal Desktop sidebar without navigation, focus changes, or an application restart.
Validation