fix(agent): drop tool_calls key when all tool_calls are deduplicated (#70126) - #70181
Closed
ms-alan wants to merge 1 commit into
Closed
fix(agent): drop tool_calls key when all tool_calls are deduplicated (#70126)#70181ms-alan wants to merge 1 commit into
ms-alan wants to merge 1 commit into
Conversation
…upes sanitize_api_messages() Step 3 deduplication creates tool_calls: [] when every tool_call in a turn has a duplicate id. This empty array then passes through to strict OpenAI-compatible providers (Qwen-series) which reject it with HTTP 400. Fix: when kept_tcs is empty after dedup, drop the tool_calls key entirely instead of setting it to []. Closes NousResearch#70126
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70126
sanitize_api_messages() Step 3 deduplication creates tool_calls: []
when every tool_call in a turn has a duplicate id. This empty array
then passes through to strict OpenAI-compatible providers (Qwen-series)
which reject it with HTTP 400. Fix: when kept_tcs is empty after
dedup, drop the tool_calls key entirely instead of setting it to [].