-
Notifications
You must be signed in to change notification settings - Fork 46.8k
feat: add opt-in lazy tool schema loading #70084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Chzrz89
wants to merge
2
commits into
NousResearch:main
Choose a base branch
from
Chzrz89:feat/lazy-tool-schema-loading-6839
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This return skips the current dynamic-schema path below it. In particular, current main rebuilds
execute_codewith only the enabled sandbox tools atmodel_tools.py:471-478;request_tool_schemalater reads the static registry entry, so lazy mode can return a schema that advertises disabled tools. Please route eager and on-demand schema construction through one canonical builder.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in d105def. The lazy early return is removed entirely — both eager and lazy modes now flow through the same canonical path (registry.get_definitions → execute_code sandbox scoping → discord intent filtering → browser_navigate cross-ref stripping → sanitization). Lazy compaction runs as a post-processing step after all dynamic-schema work. Added a
skip_lazy_compactionparameter sorequest_tool_schemacan retrieve the full dynamic schemas viaget_tool_definitions(skip_lazy_compaction=True)instead of reading the static registry entry.