fix(cli): hermes memory status now reads actual config instead of hardcoded 'always active' - #70065
Merged
kshitijk4poor merged 3 commits intoJul 23, 2026
Conversation
…d 'always active'
The 'Built-in: always active' label was a hardcoded string that never
reflected the user's actual configuration. It now shows three separate
indicators, each reading from the real source of truth:
- Memory injection: reads memory.memory_enabled from config.yaml
- User profile: reads memory.user_profile_enabled from config.yaml
- Memory tool: checks if 'memory' is in platform_toolsets.cli
(or defaults to enabled if no explicit list)
Before:
Built-in: always active
After:
Built-in (MEMORY.md / USER.md):
Memory injection: disabled ✗
User profile: disabled ✗
Memory tool: disabled ✗
Add tests/hermes_cli/test_memory_status.py with 11 tests covering: - No hardcoded 'always active' label - memory_enabled, user_profile_enabled, memory toolset indicators - Tool enabled/disabled via platform_toolsets.cli - Provider still shown alongside indicators Add huajiang@tubi.tv → thirstycrow to AUTHOR_MAP (PR NousResearch#23630 salvage).
The PR's inline toolset resolution (checking 'memory' in cli_toolsets list) produced wrong results for composite toolsets like 'hermes-cli' which expand to include the memory tool. Replace with the canonical _get_platform_tools() from tools_config.py which correctly handles composite toolsets and all edge cases. Update tests to mock _get_platform_tools instead of raw config.
kshitijk4poor
added
type/bug
This was referenced Jul 23, 2026
Closed
alt-glitch
added
tool/memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes memory statusnow shows actual config state for memory injection, user profile, and memory tool instead of a hardcoded "always active" label.Changes
hermes_cli/memory_setup.py:cmd_status()readsmemory_enabled,user_profile_enabled, and uses the canonical_get_platform_tools()resolver to check if the memory tool is enabled for the CLI platform. Displays three config-aware indicators with ✓/✗ marks.tests/hermes_cli/test_memory_status.py: 10 tests covering all indicators, disabled states, toolset resolution, and provider display.scripts/release.py: AUTHOR_MAP entry forhuajiang@tubi.tv→thirstycrow.Validation
tests/hermes_cli/test_memory_status.pyNotes
hermes-cliexpands to includememorybut the inlineincheck missed it). Fixed by using the canonical_get_platform_tools()resolver fromtools_config.py.Closes #23630. Based on #23630 by @thirstycrow and #18491 by @onurkarali.