Skip to content

feat(dashboard): HERMES_DASHBOARD_EXTRA_HOSTS for reverse-proxy WS Origin #70064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dbillionaer wants to merge 1 commit into from
Closed

feat(dashboard): HERMES_DASHBOARD_EXTRA_HOSTS for reverse-proxy WS Origin #70064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions hermes_cli/web_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,15 @@ def _is_accepted_host(host_header: str, bound_host: str) -> bool:
host_only = h.rsplit(":", 1)[0] if ":" in h else h
host_only = host_only.lower()

# Operator-defined extra accepted hosts (e.g. Tailscale MagicDNS names
# behind a reverse proxy). Allows the WS Origin check to accept proxied
# origins without binding publicly or disabling the Host/Origin guard.
_extra_hosts = os.environ.get("HERMES_DASHBOARD_EXTRA_HOSTS", "")
if _extra_hosts and host_only in {
h.strip().lower() for h in _extra_hosts.split(",") if h.strip()
}:
return True

# 0.0.0.0 bind means operator explicitly opted into all-interfaces
# (requires --insecure per web_server.start_server). No Host-layer
# defence can protect that mode; rely on operator network controls.
Expand Down