fix(windows): stop pythonw backends during desktop update - #70033
Open
xuezhaolan wants to merge 1 commit into
Open
fix(windows): stop pythonw backends during desktop update#70033xuezhaolan wants to merge 1 commit into
xuezhaolan wants to merge 1 commit into
Conversation
Collaborator
Related: #65935 and #70026. This is a focused bootstrap-installer repair for the pythonw lock case, while #65935 covers the same update path plus base-interpreter trampoline and broader venv-holder detection. Please consolidate the overlapping bootstrap changes rather than treating either PR as a duplicate. |
Contributor
|
Thanks for narrowing the process sweep to the install venv rather than killing every Python process. Problems
Suggested changes
Automated hermes-sweeper review. |
This was referenced Aug 3, 2026
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pythonw.exe/python.exe, not justhermes.exe.venvpath so unrelated Python or Hermes processes are not touched.Rationale
The Windows desktop/gateway backend can run as
pythonw.exe -m hermes_cli.main ... gateway run. If that process survives handoff, it can keep files invenvlocked and make the update/rebuild fail withAccess deniedeven aftertaskkill /IM hermes.exesucceeds.Closes #70026
Test Plan
git diff --check -- apps/bootstrap-installer/src-tauri/src/update.rsNote: Rust toolchain is not installed in this sandbox (
cargomissing), socargo fmt/cargo testcould not be run locally.