fix(telegram): align standalone media upload timeout with gateway - #69984
Open
nateEc wants to merge 1 commit into
Open
fix(telegram): align standalone media upload timeout with gateway#69984nateEc wants to merge 1 commit into
nateEc wants to merge 1 commit into
Conversation
Contributor
|
Thanks for addressing the real adapter-side PTB timeout split. Problems
Suggested changes
Automated hermes-sweeper review. |
nateEc
force-pushed
the
codex/fix-62936-telegram-media-timeout
branch
from
July 30, 2026 07:53
759e33a to
a812a05
Compare
Contributor
Author
|
Addressed the sweeper findings in
Validation: 67 focused and adjacent Telegram tests passed; Ruff and |
nateEc
force-pushed
the
codex/fix-62936-telegram-media-timeout
branch
from
July 30, 2026 08:10
a812a05 to
a34616f
Compare
Contributor
|
Independent end-to-end validation from a macOS Hermes deployment:
This provides real-file E2E confirmation that configuring PTB’s upload-specific |
- 让直连与代理发送都显式配置 60 秒媒体写入超时。 - 保持与网关现有策略一致,不新增或恢复用户配置项。 - 覆盖独立发送的直连和代理请求,并保留贡献者归属映射。 - 已通过目标 pytest、Ruff 与差异检查。
nateEc
force-pushed
the
codex/fix-62936-telegram-media-timeout
branch
from
August 19, 2026 06:20
a34616f to
10ccb12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
media_write_timeoutfor the standalone Telegram sender used byhermes send, cron, and other out-of-gateway callersTELEGRAM_PROXYrequest transportsWhy this shape
Current
mainalready fixes media uploads in the gateway and intentionally standardizes that path on a fixed 60-second stall timeout. The remaining gap is the standalone sender intools/send_message_tool.py, where PTB otherwise retains its 20-second media-write default.Verification
python -m pytest -q tests/tools/test_send_message_telegram_proxy.py— 2 passeduvx ruff check tools/send_message_tool.py tests/tools/test_send_message_telegram_proxy.pygit diff --checkFixes #62936