You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the focused fix. The normal Chat Completions premise is confirmed on current main: agent/transports/chat_completions.py:25-32 only clamps ultra for GPT-5.6, while the Nous profile forwards enabled reasoning configuration at plugins/model-providers/nous/__init__.py:60-68.
Problems
agent/chat_completion_helpers.py:2199-2206 builds session-summary Chat Completions requests directly and assigns agent.reasoning_config verbatim to summary_extra_body["reasoning"]; it bypasses ChatCompletionsTransport._reasoning_config_for_model(). A GLM-5.2 summary request can therefore still emit unsupported ultra after this PR.
Suggested changes
Reuse the same model-aware normalization before constructing the summary reasoning body, and add a regression test for that direct summary path.
Thanks for the fix. The GLM-5.2 ultra leak is resolved on main: PR #90330 clamped ultra → max unconditionally at the chat-completions chokepoint, and PR #90350 replaced the per-vendor guard lists with a canonical effort ladder + declared per-route vocabularies (GLM-5.2's two-level high/max set included, shared by the zai and opencode-zen profiles) — so this can't regress per-vendor again. Your model-name-token approach was a reasonable extension of the pattern that existed at the time; the class fix just went one level deeper. Closing with thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/agentCore agent runtime: loop, agent_init, prompt builder, context-compression, responses endpointP2Medium — degraded but workaround existsprovider/nvidiaNVIDIA NIMprovider/zaiZAI providersweeper:blast-moderateSweeper blast radius: moderate — a subsystem or single platformsweeper:risk-compatibilitySweeper risk: may break existing users, config, migrations, defaults, or upgradestype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ultrato GLM-5.2's supportedmaxreasoning effort before provider-specific request shapingnvidia/z-ai/glm-5.2routeTesting
scripts/run_tests.sh tests/agent/transports/test_chat_completions.py -q(94 passed).venv/Scripts/ruff.exe check agent/transports/chat_completions.py tests/agent/transports/test_chat_completions.pyFixes #69855