fix(desktop): route tiled session resumes to the owning profile - #69887
Merged
Conversation
`resumeTile` — the cold-resume path for a session opened in a tile / split
pane — resumed with `{ session_id, cols }` and read messages with no profile,
so a tile opening a session from another profile let the gateway fall back to
the launch-profile DB and fork the conversation into the wrong profile: the
same cross-profile bleed the recovery resumes had (#67603), just a sibling
call path. Resolve the owning profile via the shared `resolveSessionProfile`
and carry it on both the transcript prefetch and the resume RPC.
Co-authored-by: oliviaaaa7788 <oliviaaaa7788@users.noreply.github.com>
OutThisLife
enabled auto-merge
July 23, 2026 05:20
Contributor
૮ >ﻌ< ა ci reviewran on c3602f7 all good! |
alt-glitch
added
type/bug
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…e-profile fix(desktop): route tiled session resumes to the owning profile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69861, which fixed the #67603 cross-profile session bleed on the recovery resumes and the right-click branch. Auditing every
session.resumecall site turned up one path that PR missed: the tiled / split-pane cold resume.resumeTilebound a runtime with{ session_id, cols }and read the transcript withgetSessionMessages(storedSessionId)— both without a profile. A tile can open a session owned by any profile, not just the active one, so the gateway fell back to the launch-profile DB and forked the conversation into the wrong profile — the same bleed #69861 closed, just a sibling call path.Fix: resolve the owning profile through the shared
resolveSessionProfile(cache → active backend → cross-profile probe, added in #69861) and carry it on both the prefetch and the resume RPC. Same one-line pattern the recovery paths already use.Tests
getSessionMessagesand thesession.resumeRPC.Checks
vitest run src/app/contrib/hooks/use-session-tile-delegate.test.ts: 2 passedtsc --noEmit: clean (unchanged from fix(desktop): end the #67603 model-switch dup, cross-profile session bleed, and [System:] bubble #69861)eslinton changed files: cleanCo-authored-by: oliviaaaa7788 oliviaaaa7788@users.noreply.github.com