Repository navigation
fix(cron): persist attach-to-session updates - #69647
Closed
alexwill87 wants to merge 2 commits into
Closed
alexwill87 wants to merge 2 commits into
alexwill87 wants to merge 2 commits into
Conversation
Collaborator
|
Thanks for tracing the registered-tool boundary. The focused cron fix is still needed on current main: Problems
Suggested changes
This is an automated hermes-sweeper review. |
12 of 19 tasks
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attach_to_sessionthrough the registeredcronjobtool handler.falseas the per-job override ofcron.mirror_delivery.Validation
scripts/run_tests.sh tests/tools/test_cronjob_tools.py -v --tb=short(78 passed)scripts/run_tests.sh tests/cron/test_scheduler.py -v --tb=short(222 passed)git diff --check