Skip to content

fix(cron): persist attach-to-session updates - #69647

Closed
alexwill87 wants to merge 2 commits into
NousResearch:mainfrom
alexwill87:fix/cron-attach-to-session-update-t_da46e95a
Closed

alexwill87 wants to merge 2 commits into
NousResearch:mainfrom
alexwill87:fix/cron-attach-to-session-update-t_da46e95a

Conversation

@alexwill87

Copy link
Copy Markdown

Summary

  • Forward attach_to_session through the registered cronjob tool handler.
  • Preserve explicit false as the per-job override of cron.mirror_delivery.
  • Add an E2E temporary-HERMES_HOME create/update/readback regression test for true then false.

Validation

  • scripts/run_tests.sh tests/tools/test_cronjob_tools.py -v --tb=short (78 passed)
  • scripts/run_tests.sh tests/cron/test_scheduler.py -v --tb=short (222 passed)
  • git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management comp/dashboard Web dashboard / control panel UI (dashboard/, landing) comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state labels Jul 22, 2026
@alt-glitch

Copy link
Copy Markdown

This was generated by AI during triage.

Duplicate of #57556 for the cronjob handler's attach_to_session passthrough. #57556 already covers the same registered-tool boundary; this PR also bundles unrelated changes that should be split before review.

@teknium1

Copy link
Copy Markdown
Collaborator

Thanks for tracing the registered-tool boundary. The focused cron fix is still needed on current main: tools/cronjob_tools.py:1039-1042 exposes attach_to_session, and cronjob() accepts/persists it (:643, :716, :894-895), but the registered handler at :1078-1100 does not forward it.

Problems

  • The PR also includes unrelated commit 87c8244f150f (25 files, +2573/-328), including agent-loop, Kanban, dashboard-auth, and Langfuse work. Please keep this fix focused; AGENTS.md:102-107 also requires behavioral settings such as the added HERMES_KANBAN_BUDGET_PRESTOP_REMAINING to use config.yaml.
  • Explicit False is a meaningful override because cron/scheduler.py:633-639 gives it precedence over cron.mirror_delivery, but _format_job at tools/cronjob_tools.py:531-565 does not return either boolean. The new test verifies storage but not that update readback preserves false.

Suggested changes

  • Isolate the registry forwarding fix and its regression test from commit 87c8244f150f.
  • Return either stored boolean from _format_job and assert the registered-handler update response contains attach_to_session: false.

This is an automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform area/sessions Session lifecycle, resume, persistence, history labels Jul 30, 2026
@kshitijk4poor

Copy link
Copy Markdown

The attach_to_session persistence fix this PR set out to make has been salvaged onto current main via #95366 (from #84829). The remainder of this diff mixes a large amount of unrelated kanban/dashboard/langfuse work into the same branch, which made it unsalvageable as a unit. Closing — if any of the other changes here are still relevant against current main, please resubmit them as focused single-concern PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sessions Session lifecycle, resume, persistence, history comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management comp/dashboard Web dashboard / control panel UI (dashboard/, landing) comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants