fix(slack): preserve legacy attachment URLs - #69620
Open
jcarugati wants to merge 1 commit into
Open
Conversation
jcarugati
marked this pull request as ready for review
July 23, 2026 00:49
Contributor
|
Thanks for the focused Slack rendering fix. The premise remains valid on current main: No additional correctness or design-fit changes identified. This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preserves HTTP(S) URLs carried by legacy Slack attachments when rendering fetched thread context and thread-parent reply context.
Current
mainalready merges visible legacy attachment text and top-level Block Kit URLs. However, its URL walker only receives top-levelblocks, so attachment fields such astitle_link,author_link, andfrom_url—plus URLs in attachment-nested Block Kit—are omitted even though the attachment title/text remains visible.This follows up on #69316 and keeps the same renderer, URL filtering, and discovery-order deduplication.
Related Issue
Follow-up to #69316. Searches for the affected legacy attachment URL fields found no open issue or equivalent PR.
Type of Change
Changes Made
blocksandattachmentsthrough that single walker.title_link,author_link,from_url, and attachment-nested Block Kit URLs.How to Test
_render_message_textoutput alongside existing top-level Block Kit URLs.Validation
scripts/run_tests.sh tests/gateway/test_slack*.py -q— 544 passed.venv/bin/ruff check .— passed.venv/bin/python scripts/check-windows-footguns.py --all— passed.venv/bin/python -m compileall -q plugins/platforms/slack/adapter.py tests/gateway/test_slack_approval_buttons.py— passedgit diff upstream/main...HEAD --check— passedCompatibility
Checklist