fix(cron): isolate cron approval context - #69566
Closed
seungjins wants to merge 1 commit into
Closed
Conversation
Collaborator
(cherry picked from commit 27346c2ba8da202fb41f2fa8877a45563a1d7f45)
seungjins
force-pushed
the
fix/cron-approval-context-leak-v2
branch
from
July 22, 2026 19:36
22b4817 to
410a2ac
Compare
Author
|
Closing as duplicate of #58663, which contains the same ContextVar isolation plus the stronger token-reset/fallback coverage and has a green required-check suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a current-
mainre-derivation of the intent in #36004, whose original fork branch is no longer writable by the submitting account and has become conflicting.Verification
pytest tests/gateway/test_session_env.py tests/tools/test_execute_code_approval_cluster.py tests/tools/test_cron_approval_mode.py tests/cron/test_cron_script.py tests/cron/test_scheduler.py -q