fix(compression): make manual compression feedback truthful - #6944
Closed
bobashopcashier wants to merge 2 commits into
Closed
fix(compression): make manual compression feedback truthful#6944bobashopcashier wants to merge 2 commits into
bobashopcashier wants to merge 2 commits into
Conversation
bobashopcashier
force-pushed
the
fix/6202-compress-response-truthfulness
branch
from
April 10, 2026 06:30
b06576e to
9b2fbd5
Compare
bobashopcashier
force-pushed
the
fix/6202-compress-response-truthfulness
branch
from
April 10, 2026 06:33
9b2fbd5 to
e4fb524
Compare
Contributor
|
Merged via #7541 with authorship preserved. Thanks for the contribution! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes manual compression feedback truthful across both user-facing entrypoints: gateway
/compressand CLI manual compression. No-op results are detected by comparing the pre/post transcript, token counts are labeled as rough transcript estimates, and cases where fewer messages still yield a higher rough estimate get an explicit explanatory note instead of misleading success copy.Related Issue
Fixes #6202
Fixes #6217
Related: #6270
Separate env/pairing hardening is tracked in PR #6956
Type of Change
Changes Made
gateway/run.pyto report no-op compression truthfully and explain rough transcript estimate increases after summary rewritescli.pyso manual compression uses the same truthful messaging instead of always printing a success banner/compressand CLI manual compression outputHow to Test
/Users/kennyxie/Documents/Code/clawspace/hermes-agent/.venv/bin/python -m pytest tests/gateway/test_compress_command.py tests/cli/test_manual_compress.py -qChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
/Users/kennyxie/Documents/Code/clawspace/hermes-agent/.venv/bin/python -m pytest tests/gateway/test_compress_command.py tests/cli/test_manual_compress.py -q→4 passed