fix(kanban): preserve creator chat scope for terminal wakes - #69391
Closed
worlldz wants to merge 1 commit into
Closed
fix(kanban): preserve creator chat scope for terminal wakes#69391worlldz wants to merge 1 commit into
worlldz wants to merge 1 commit into
Conversation
Collaborator
This was referenced Jul 23, 2026
Merged
Contributor
|
Superseded by PR #72191, which fixes this bug via #58615 (@ljsdut, earliest submission) plus the CLI call-site half of #64113 (@zmlgit). Your PR converged on the same design all four competing fixes landed on — chat_type persistence, group fallback, self-heal backfill — which is good corroboration that the design was right; it lost the arbitration only on submission date and auto-subscribe-path coverage. Thanks for the work, and the tests were solid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68874
Related to #56580
When a task is created from a direct message, the Kanban notifier can later wake the agent using a different session scope.
The notification itself reaches the correct chat, but the synthetic wake event was rebuilt with chat_type="group". DM and group conversations use different session keys, so the continuation could land in a fresh group session instead of the DM session that created the task.
This change:
Regression coverage includes DM wake routing, legacy database migration, chat type normalization, re-subscription behavior, and tool auto-subscription.
Validation:
162 passed