Fix P1 Windows packaging (#69179) and Terminal Deadlock (#69212) - #69330
Fix P1 Windows packaging (#69179) and Terminal Deadlock (#69212)#69330JonthanaHanh wants to merge 4 commits into
Conversation
|
too large to review safely This PR changes 10107 production lines before tests and docs. Please split it or add a focused justification if it should stay together. Signed: GPT-5.6-terra-low in Codex |
|
Closing — both halves of this rollup are resolved on main. The #69179 Windows packaging failure is fixed by #71119 (PE integrity gate + rollback on the rebuilt Hermes.exe) and #71218 (OS-native architecture detection); the #69212 terminal deadlock was fixed separately and that issue is closed. This branch also bundles unrelated changes across the codex adapter, compressor, and conversation loop that can't be reviewed as one unit — if any of those address a still-live bug, please open focused single-concern PRs against current main. Thanks @JonthanaHanh for the report-driven work. |
This PR addresses two P1 issues identified in the repository audit:
Windows Packaging Architecture Enforcement ([Bug]: This app can't run on your computer (此应用无法在你的电脑上运行) #69179):
apps/desktop/scripts/stage-native-deps.mjsto explicitly verify that x64 binaries are staged when targetingwin32-x64.Terminal Compound Background Command Deadlock (fix(gateway): suppress the duplicate clarify tool-progress bubble (#69175) #69212):
tools/terminal_tool.py's_rewrite_compound_backgroundfunction to wrap trailing backgrounded commands in braces:A && B &->A && { B & }.Verified the regex and logic for both fixes. Proceeding to P2 remediations next.