fix(codex): preserve commentary across interleaved output items - #69260
fix(codex): preserve commentary across interleaved output items#69260ruizanthony wants to merge 3 commits into
Conversation
|
Maintainer action needed: the CI workflows on this PR are awaiting approval (first-time contributor gating) — no checks have run yet on head |
|
Rebased onto current master ( |
780aefe to
1007993
Compare
|
Thanks for the focused follow-up. The premise remains valid on current main: The proposed item-id/output-index association addresses that state-model gap, and the added regression coverage exercises interleaved commentary/final items, function-call interleaving, alias mismatches, and the Relay concrete-response path. I found no blocking correctness or design-fit issue in the diff. Automated hermes-sweeper review. |
Summary
Context
PR #59831 was superseded by #66115, which landed the core commentary-to-interim routing and
display.show_commentarycontrol. This is a narrow follow-up for residual stream-shape cases reproduced against currentmain; it does not reintroduce the superseded implementation.Tests
HERMES_PYTHON=/usr/local/lib/hermes-agent/venv/bin/python ./scripts/run_tests.sh tests/run_agent/test_run_agent_codex_responses.py -q— 112 passedpython -m py_compile agent/codex_runtime.pygit diff origin/main..HEAD --check