fix(tools): bound recoverable context outputs - #69238
Open
jkobject wants to merge 1 commit into
Open
Conversation
teknium1
reviewed
Jul 30, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused work on a real current-main context-growth path.
Problems
- Blocking:
tools/session_search_tool.py:96-153truncates every string in the aggregate fallback. That includessession_idandlink;hermes_state.py:2458-2460accepts arbitrary session IDs. A valid oversized stored ID can therefore exceed the aggregate threshold and be returned only as an unusable fragment, despite recovery guidance requiring the exact ID. - The
kanban_showcontract changes from fullworker_context/comment history to bounded orientation slices, butwebsite/docs/user-guide/features/kanban.md:293,310-311,393-394and tutorial references still document the removed behavior.
Suggested changes
- Add a valid oversized-session-ID regression and define a bounded recovery behavior that does not advertise a truncated identifier as reusable.
- Update the Kanban docs with the bounded orientation and recovery model.
- Integrate against current session-search behavior, including
9bb253d4faandb93fd077c0; those paths changed after this branch's base.
This is an automated hermes-sweeper review.
Bound session-search and Kanban orientation payloads at the aggregate response layer while retaining exact session, task, graph, and attachment handles. Limit Kanban history queries before materialization, redact internal claim ownership values, and document canonical recovery paths.
jkobject
force-pushed
the
fix/context-output-bounds-upstream
branch
from
August 11, 2026 11:46
3253e69 to
69c1f0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound recoverable model-facing output from
session_searchandkanban_showso large recall/orientation results cannot immediately rebuild context after compression.The implementation preserves canonical board/session data and complete instructional
skill_viewbehavior. Model-facing views now provide bounded previews, original-size metadata, totals/omitted counts, and explicit canonical recovery instructions.Changes
session_searchsession_id,parent_session_id, andlinkrecovery handles.kanban_showkanban_attachments.Guidance and docs
worker_context.kanban_attachments, and the canonical CLI/dashboard history surfaces.Regression coverage
Adversarial tests cover:
Validation
Result: 140 passed, 2 skipped, 0 failed.
All pass. Independent pre-commit review reported no remaining security or logic blockers on revision
69c1f0ccbf24f4a8ef39746eec97fd15abd393da.Scope