fix(docs): remove stale Chinese RL training links - #69157
Conversation
|
Thanks for the focused localized-docs fix. The premise is confirmed on current main: the removed destination remains linked from No changes requested. Current main has not modified either target file since this PR's base, so salvage should be mechanical. Automated hermes-sweeper review. |
GottZ
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Summary
Two PRs address the same stale Simplified Chinese RL-training links. Both remove references to the deleted internal page, point the learning path to Atropos, remove the obsolete feature row, and replace the overview entry with Batch Processing; their only substantive differences are minor Chinese wording choices.
Related pull requests
- #69157
related— (+6/-7) — keep open with a salvage path: The focused diff removes all four shown stalerl-trainingreferences across the two zh-Hans files and aligns their destinations with the current English documentation. Consistent with the maintainer-bot keep-open verdict, the salvageable change is the complete two-file localized-docs correction; #69753 offers no distinct functional addition. - #69753 [closed]
duplicate— (+6/-7) — closed as duplicate of #69157: Its diff makes the same two-file link removals and replacements as #69157, with only minor wording differences. It remains relevant as direct diff evidence for the duplicate relationship, which was identified by contributor alt-glitch and accepted in the subsequent closure discussion.
Duplicates
#69753 is a duplicate of #69157: both modify the same two zh-Hans files and perform the same stale-link removal, Atropos substitution, obsolete-row deletion, and Batch Processing replacement.
Suggested consolidation
Keep #69157 open with a salvage path: preserve its focused two-file correction, which removes the demonstrated stale internal links and mirrors the current English learning path and feature overview. Leave #69753 closed as a duplicate of #69157 because its diff contains no distinct fix to retain.
Complex graph
flowchart LR
classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
classDef best stroke-width:3px,stroke:#b45309
classDef target stroke-width:3px,stroke:#4338ca
subgraph Dup69157 ["PRs duplicating each other"]
P69157["PR #69157 (open)"]
P69753["PR #69753 (closed)"]
end
class P69157 open
class P69753 closed
class P69157 target
click P69157 "https://github.com/NousResearch/hermes-agent/pull/69157"
click P69753 "https://github.com/NousResearch/hermes-agent/pull/69753"
Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).
Cross-PR triage: Reviewed 2 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 8 kB of PR diffs, 2 kB of issue/PR text, <1 kB of discussion (3 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.
|
Decision: keep this PR open as the surviving fix for the stale zh-Hans RL-training links. Evidence checked against current
With #69753 already closed as a duplicate of this PR, there is no remaining overlap to reconcile, and no further change is needed on this branch to implement the decision. |
Summary
Root cause
The built-in Atropos/RL training integration and
rl-training.mdwere removed in #26106. A later Simplified Chinese translation reintroduced references to that deleted page, causing the localized links to lead to 404 pages.User impact
Simplified Chinese readers can now navigate from the features overview to the existing Batch Processing documentation, and the learning path no longer advertises a removed internal page.
Validation
npm run build(passes; existing unrelated broken-link and broken-anchor warnings remain)/docs/zh-Hans/user-guide/features/batch-processing批量处理pagerl-traininglinks