Skip to content

fix(docs): remove stale Chinese RL training links - #69157

Open
DragonnZhang wants to merge 2 commits into
NousResearch:mainfrom
DragonnZhang:agent/fix-zh-rl-training-links
Open

fix(docs): remove stale Chinese RL training links#69157
DragonnZhang wants to merge 2 commits into
NousResearch:mainfrom
DragonnZhang:agent/fix-zh-rl-training-links

Conversation

@DragonnZhang

Copy link
Copy Markdown

Summary

  • replace the stale Simplified Chinese RL Training entry in the features overview with the current Batch Processing destination
  • align the Simplified Chinese learning path with the English docs by removing links to the deleted internal RL Training page and linking to the external Atropos project where appropriate

Root cause

The built-in Atropos/RL training integration and rl-training.md were removed in #26106. A later Simplified Chinese translation reintroduced references to that deleted page, causing the localized links to lead to 404 pages.

User impact

Simplified Chinese readers can now navigate from the features overview to the existing Batch Processing documentation, and the learning path no longer advertises a removed internal page.

Validation

  • npm run build (passes; existing unrelated broken-link and broken-anchor warnings remain)
  • verified the generated overview link is /docs/zh-Hans/user-guide/features/batch-processing
  • clicked the link in the locally served production build and confirmed it opens the 批量处理 page
  • confirmed the affected generated pages no longer contain rl-training links

@DragonnZhang
DragonnZhang marked this pull request as ready for review July 22, 2026 07:16
@alt-glitch alt-glitch added type/docs Documentation improvements P3 Low — cosmetic, nice to have needs-decision Awaiting maintainer decision before any implementation labels Jul 22, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused localized-docs fix. The premise is confirmed on current main: the removed destination remains linked from website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/getting-started/learning-path.md:27, :102, and :138, and from website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/user-guide/features/overview.md:46. The replacement mirrors the current English learning path at website/docs/getting-started/learning-path.md:103-108 and feature overview at website/docs/user-guide/features/overview.md:51.

No changes requested. Current main has not modified either target file since this PR's base, so salvage should be mechanical.

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users area/i18n Localization, locales, translations labels Jul 30, 2026

@GottZ GottZ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated by AI during triage.

Summary

Two PRs address the same stale Simplified Chinese RL-training links. Both remove references to the deleted internal page, point the learning path to Atropos, remove the obsolete feature row, and replace the overview entry with Batch Processing; their only substantive differences are minor Chinese wording choices.

Related pull requests

  • #69157 related — (+6/-7) — keep open with a salvage path: The focused diff removes all four shown stale rl-training references across the two zh-Hans files and aligns their destinations with the current English documentation. Consistent with the maintainer-bot keep-open verdict, the salvageable change is the complete two-file localized-docs correction; #69753 offers no distinct functional addition.
  • #69753 [closed] duplicate — (+6/-7) — closed as duplicate of #69157: Its diff makes the same two-file link removals and replacements as #69157, with only minor wording differences. It remains relevant as direct diff evidence for the duplicate relationship, which was identified by contributor alt-glitch and accepted in the subsequent closure discussion.

Duplicates

#69753 is a duplicate of #69157: both modify the same two zh-Hans files and perform the same stale-link removal, Atropos substitution, obsolete-row deletion, and Batch Processing replacement.

Suggested consolidation

Keep #69157 open with a salvage path: preserve its focused two-file correction, which removes the demonstrated stale internal links and mirrors the current English learning path and feature overview. Leave #69753 closed as a duplicate of #69157 because its diff contains no distinct fix to retain.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    subgraph Dup69157 ["PRs duplicating each other"]
        P69157["PR #69157 (open)"]
        P69753["PR #69753 (closed)"]
    end
    class P69157 open
    class P69753 closed
    class P69157 target
    click P69157 "https://github.com/NousResearch/hermes-agent/pull/69157"
    click P69753 "https://github.com/NousResearch/hermes-agent/pull/69753"
Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 2 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 8 kB of PR diffs, 2 kB of issue/PR text, <1 kB of discussion (3 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.

@DragonnZhang

Copy link
Copy Markdown
Author

Decision: keep this PR open as the surviving fix for the stale zh-Hans RL-training links.

Evidence checked against current main (fc9cbc8):

  • rl-training.md no longer exists anywhere in the repo (neither website/docs/ nor website/i18n/zh-Hans/), so the four remaining zh-Hans links to /user-guide/features/rl-training are dead: getting-started/learning-path.md lines 27, 102, 138 and user-guide/features/overview.md line 46.
  • This PR's replacements mirror the current English docs: the English learning path's "I want to train models" section describes the RL pipeline as "powered by [Atropos]" with step 3 pointing to the external Atropos repo, and the English feature overview replaces the RL entry with Batch Processing — exactly what this diff does for zh-Hans.
  • Neither target file has been modified on main since this PR's base, so the two-file diff still applies cleanly (no conflicts).

With #69753 already closed as a duplicate of this PR, there is no remaining overlap to reconcile, and no further change is needed on this branch to implement the decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/i18n Localization, locales, translations needs-decision Awaiting maintainer decision before any implementation P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants