fix(gateway): make Slack capability guidance accurate - #69094
Closed
KCAYAAI wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Slack session guidance that currently turns a gateway implementation detail into a false universal capability denial.
Hermes now distinguishes:
A configured Slack token proves gateway authentication, not model-tool exposure. Conversely, the absence of a built-in Slack tool does not prove that a deployment-specific plugin exposes no bounded Slack operations.
The conservative state therefore says that no operational Slack capability has been both declared and currently verified for the conversation; it does not claim that no Slack-related tool exists anywhere. The capability-present state lists only the declaring tool and its identifier-style operations.
Related Issue
Related to #6533 and #6536.
This is an explicit metadata-based alternative to #62135, #6545, #36676, and #68627. Those PRs soften the note or infer capability from known/Slack-looking tool or MCP names. This change deliberately does not infer operational capability from tokens, executables, terminal access, environment names, tool names, or MCP server names.
Type of Change
Changes Made
tools/registry.pyHERMES_HOME.hermes_cli/plugins.pyplatform_capabilitiesandplatform_capability_check_fnregistration arguments.model_tools.pygateway/run.pygateway/session.pysend_messageclaim.How to Test
git diff --check, and the documentation production build.Checklist
Code
fix(scope):,feat(scope):, etc.)Documentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleis N/A; no configuration key was addedCONTRIBUTING.md/AGENTS.mdchanges are N/Aasyncio.to_thread,pathlib, and existing profile context variablesScreenshots / Logs
Focused implementation suite:
Relevant broader verification after the final rebase:
Complete canonical suite after the final rebase:
These failures do not execute the new Slack capability metadata, profile dispatch gates, prompt rendering, or conversation snapshot path. The focused and broader feature suites above are green.
Type/format baseline review:
No live Slack API calls or test posts were made. No credentials, scopes, permissions, or gateway processes were changed. After installation, restart each affected gateway so plugin registration and in-memory conversation capability snapshots are rebuilt; the next turn may resume the same persisted conversation.