fix(compression): make continuation rotation atomic - #68929
Closed
trac3r00 wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
Author
|
Confirmed. #64373 predates this PR and covers the same atomic parent-to-child rotation while also adding durable lease validation and broader concurrency regression coverage. Closing this duplicate in favor of #64373; credit to @yingliang-zhang for the earlier, more complete implementation. [bob] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Bob]
Summary
BEGIN IMMEDIATEtransactionRoot cause
Legacy rotation called
end_session()andcreate_session()as separate transactions. Auto-prune could select and delete the newly ended parent between those writes, so the child insert lost its lineage target and the live agent could continue with a session id that was never persisted.Verification
uv run pytest -q tests/agent/test_compression_rotation_state.py tests/agent/test_compression_concurrent_fork.py tests/test_hermes_state.py— 435 passedparent_ended=true, child_visible=false, confirming the test distinguishes the regressionuv run ruff check agent/conversation_compression.py hermes_state.py tests/agent/test_compression_rotation_state.py— clean