[Bob] fix: namespace Slack sessions by workspace - #68925
Closed
trac3r00 wants to merge 1 commit into
Closed
Conversation
alt-glitch
added
type/bug
teknium1
added a commit
that referenced
this pull request
Jul 23, 2026
Conflict-resolution follow-up composing #68925 (Bob) with the already- applied #20583/#66398 (jordanhubbard) recovery design: - #68925's caller-level second _query_recoverable_session pass (via lookup_session_key=) referenced a variable that no longer exists — the legacy exact-key fallback now lives INSIDE _query_recoverable_session, which also claims the legacy key once per process and rewrites the peer row to the scoped key. Drop the dead caller-level pass. - Keep #68925's _recovered_row_matches_source_scope origin guard wired into both recovery paths: a scoped channel lookup refuses rows whose recorded origin names another workspace (or no workspace at all). - Routing-index migration adoption policy documented at the site: origin names a workspace -> exact match only; scope-less DM -> first workspace claims once; scope-less channel -> refuse.
teknium1
added a commit
that referenced
this pull request
Jul 23, 2026
Conflict-resolution follow-up composing #68925 (Bob) with the already- applied #20583/#66398 (jordanhubbard) recovery design: - #68925's caller-level second _query_recoverable_session pass (via lookup_session_key=) referenced a variable that no longer exists — the legacy exact-key fallback now lives INSIDE _query_recoverable_session, which also claims the legacy key once per process and rewrites the peer row to the scoped key. Drop the dead caller-level pass. - Keep #68925's _recovered_row_matches_source_scope origin guard wired into both recovery paths: a scoped channel lookup refuses rows whose recorded origin names another workspace (or no workspace at all). - Routing-index migration adoption policy documented at the site: origin names a workspace -> exact match only; scope-less DM -> first workspace claims once; scope-less channel -> refuse.
Contributor
Author
|
Closing in favor of #70190, which covers the same workspace-isolation class more completely across both Slack DMs and group channels while preserving legacy session compatibility. Thanks for carrying the fix forward and crediting this attempt. [bob] |
teknium1
added a commit
that referenced
this pull request
Jul 23, 2026
Conflict-resolution follow-up composing #68925 (Bob) with the already- applied #20583/#66398 (jordanhubbard) recovery design: - #68925's caller-level second _query_recoverable_session pass (via lookup_session_key=) referenced a variable that no longer exists — the legacy exact-key fallback now lives INSIDE _query_recoverable_session, which also claims the legacy key once per process and rewrites the peer row to the scoped key. Drop the dead caller-level pass. - Keep #68925's _recovered_row_matches_source_scope origin guard wired into both recovery paths: a scoped channel lookup refuses rows whose recorded origin names another workspace (or no workspace at all). - Routing-index migration adoption policy documented at the site: origin names a workspace -> exact match only; scope-less DM -> first workspace claims once; scope-less channel -> refuse.
Contributor
Contributor
Author
|
Confirmed — #70190 is the stronger complete fix, especially with DM scoping and legacy-key compatibility. Thanks for preserving the attribution. [bob] |
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
Conflict-resolution follow-up composing NousResearch#68925 (Bob) with the already- applied NousResearch#20583/NousResearch#66398 (jordanhubbard) recovery design: - NousResearch#68925's caller-level second _query_recoverable_session pass (via lookup_session_key=) referenced a variable that no longer exists — the legacy exact-key fallback now lives INSIDE _query_recoverable_session, which also claims the legacy key once per process and rewrites the peer row to the scoped key. Drop the dead caller-level pass. - Keep NousResearch#68925's _recovered_row_matches_source_scope origin guard wired into both recovery paths: a scoped channel lookup refuses rows whose recorded origin names another workspace (or no workspace at all). - Routing-index migration adoption policy documented at the site: origin names a workspace -> exact match only; scope-less DM -> first workspace claims once; scope-less channel -> refuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
uv run python -m pytest tests/gateway/test_session.py -q(130 passed)uv run python -m ruff check gateway/session.py tests/gateway/test_session.pyuv run python -m compileall -q gateway/session.py