fix(telegram): skip rich entity detection for emails - #68757
Conversation
|
Thanks for the focused fix. The premise remains present on current main: The PR's centralized, email-shaped predicate therefore reaches all reported delivery paths without the broader every- Automated hermes-sweeper review. |
SummaryTwo open PRs address #68754 through the shared Telegram rich-message payload builder: #68757 uses an email-token predicate matching the reported failure, while #68852 triggers on every Related pull requests
Duplicates#68757 and #68852 substantially duplicate the Telegram fix in the same shared payload builder; #68852 is the broader mixed-scope variant. Suggested consolidationKeep #68757 open with a salvage path: retain its centralized email-token predicate and focused regression tests, consistent with the maintainer-bot keep-open verdict. Close #68852 as a duplicate of #68757 despite its COMMENTED keep-open review, because its diff uses the contributor-rejected every- Complex graphflowchart LR
classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
classDef best stroke-width:3px,stroke:#b45309
classDef target stroke-width:3px,stroke:#4338ca
I68754(["issue #68754 (open)"])
subgraph Dup68757 ["PRs duplicating each other"]
P68757["PR #68757 (open)"]
P68852["PR #68852 (open)"]
end
P68757 -->|best fix| I68754
class I68754 open
class P68757 open
class P68852 open
class P68757 best
class P68757 target
click I68754 "https://github.com/NousResearch/hermes-agent/issues/68754"
click P68757 "https://github.com/NousResearch/hermes-agent/pull/68757"
click P68852 "https://github.com/NousResearch/hermes-agent/pull/68852"
Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label). Cross-PR triage: Reviewed 2 pull requests and 1 issue in this complex. Each diff was read against this issue; Assessment working set: 11 kB of PR diffs, 3 kB of issue/PR text, 2 kB of discussion (4 comments), 3 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch. |
dc9b788 to
4ef33c5
Compare
What does this PR do?
Keeps Telegram rich messages deliverable when status, draft, or final text contains an email address.
skip_entity_detectionbefore Telegram can auto-link an invalid provider-prefixed email entityRelated Issue
Fixes #68754
Type of Change
How Has This Been Tested?
pytest tests/gateway/test_telegram_rich_messages.py tests/gateway/test_telegram_rich_newlines.py -q(85 passed)ruff check plugins/platforms/telegram/adapter.py tests/gateway/test_telegram_rich_newlines.pygit diff --checkChecklist