Skip to content

feat(desktop): add custom endpoint quick-edit card to API Keys page - #68591

Closed
eiritsu wants to merge 3 commits into
NousResearch:mainfrom
eiritsu:feat/custom-endpoint-card-clean
Closed

feat(desktop): add custom endpoint quick-edit card to API Keys page#68591
eiritsu wants to merge 3 commits into
NousResearch:mainfrom
eiritsu:feat/custom-endpoint-card-clean

Conversation

@eiritsu

@eiritsu eiritsu commented Jul 21, 2026

Copy link
Copy Markdown

Summary

Adds a compact inline card under the LocalEndpointRow in the API Keys page, giving users a quick-edit affordance for their active custom endpoint's base_url and api_key without leaving the page.

This sits on top of PR #69258 which adds legacy custom_providers: management to the existing full Custom Endpoints settings page. That page (preserved as-is) handles multi-endpoint CRUD, API compatibility mode, and legacy entries; the new card is just a faster inline shortcut for the common single-endpoint case.

Changes

New CustomEndpointKeyCard component (providers-settings.tsx)

  • Inline card directly under <LocalEndpointRow /> in the API Keys view
  • Edit base_url and api_key in place
  • Uses the same plural /api/providers/custom-endpoints REST surface as upstream main
  • Resolves the active endpoint via getCustomEndpoints() and passes its id/name/model through saveCustomEndpoint() on every save
  • Falls back to the existing <LocalEndpointRow /> → full page for new endpoints / multiple endpoints / legacy entries

i18n

  • Added customEndpoint translation block (en + zh + types)

Out of scope (already handled by #69258)

Design notes

  • Plural API only — no single-endpoint route divergence from upstream
  • Reads the current endpoint's identity from getCustomEndpoints() so backend writes stay scoped to a known provider key (no orphan name derivation)
  • Backend web_server.py is unchanged from fix(desktop): delete legacy custom providers #69258's branch

@alt-glitch alt-glitch added type/feature New feature or request P2 Medium — degraded but workaround exists comp/desktop Electron desktop app (apps/desktop/*) comp/cli CLI entry point, hermes_cli/, setup wizard area/config Config system, migrations, profiles needs-decision Awaiting maintainer decision before any implementation sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades labels Jul 21, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Related: #68043 and #68427 are closed predecessors. The current patch replaces the full multi-endpoint flow with a first-entry API-keys card, so a maintainer decision is needed on that compatibility trade-off before consolidation.

@eiritsu
eiritsu force-pushed the feat/custom-endpoint-card-clean branch 4 times, most recently from b209462 to d72cc34 Compare July 22, 2026 02:50
@eiritsu
eiritsu force-pushed the feat/custom-endpoint-card-clean branch 2 times, most recently from d7d1a10 to 424871f Compare July 23, 2026 13:47
@eiritsu

eiritsu commented Jul 23, 2026

Copy link
Copy Markdown
Author

Coordinating with PR #69258

Noticed PR #69258 (fix(desktop): delete legacy custom providers) also touches Custom Endpoints. Currently coordinating with @SacrEllfarch on how to align the two PRs.

Current state

Coordination options under discussion

Links

eiritsu added 2 commits July 24, 2026 13:08
Adds a compact inline card under the LocalEndpointRow in the API Keys page,
giving users a quick-edit affordance for their active custom endpoint's
base_url and api_key without leaving the page.

- Calls plural /api/providers/custom-endpoints (aligned with upstream main)
- Falls back to the existing CustomEndpointsSettings full page for advanced
  flows (new/edit multiple, API compatibility mode, legacy entries)
- Sits on top of NousResearch#69258 which adds legacy custom_providers management to
  the full page
@eiritsu
eiritsu force-pushed the feat/custom-endpoint-card-clean branch from 424871f to 915985a Compare July 24, 2026 05:24
@eiritsu eiritsu changed the title feat(desktop): consolidate Custom Endpoint into API Keys card with config + env sync feat(desktop): add custom endpoint quick-edit card to API Keys page Jul 24, 2026
@eiritsu

eiritsu commented Jul 29, 2026

Copy link
Copy Markdown
Author

Closing this overlapping implementation in favor of PR #69258, which is the coordinated Custom Endpoint path.

@eiritsu eiritsu closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard comp/desktop Electron desktop app (apps/desktop/*) needs-decision Awaiting maintainer decision before any implementation P2 Medium — degraded but workaround exists sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants