fix(doctor): decode subprocess output as utf-8 - #68546
Closed
shaoohh wants to merge 1 commit into
Closed
Conversation
Contributor
|
Closing as resolved by PR #70875 (merged, commit 0f732cb), which closed out this bug class codebase-wide: every |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm audit --json.Root cause
subprocess.run(..., text=True)used the Windows ANSI code page by default. On GBK/CP936 hosts, UTF-8 subprocess output containing bytes invalid in GBK could raise a background-readerUnicodeDecodeError, leaving.stdoutunavailable and causing doctor checks to fail or be silently skipped.Testing
python -m py_compile hermes_cli/doctor.py tests/hermes_cli/test_doctor.py—�.scripts/run_tests.sh tests/hermes_cli/test_doctor.py -q(blocked locally: no project Python 3.11-3.13 virtual environment is installed; the only available Python is 3.14, which the project explicitly excludes)Fixes #49499