Fix Slack table column settings validation - #68434
Closed
tishan-jayasekera wants to merge 1 commit into
Closed
Conversation
tishan-jayasekera
marked this pull request as ready for review
July 21, 2026 05:52
Collaborator
Duplicate of #65355: both replace null Slack table column_settings placeholders with valid objects while retaining positional alignment. |
Author
|
Closing in favor of #57128, which addresses the same I independently validated #57128's exact head: 277 focused Slack tests pass, the diff is clean, upstream CI is green, and the root cause is corroborated by a private Slack DM canary. Keeping one canonical PR should make the upstream merge path clearer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
column_settingsentry when a Markdown table requests any non-default alignment{ "align": "left" }placeholders instead ofnullcolumn_settingswhen every column uses Slack's default left alignmentRoot cause
The Block Kit renderer used
nullplaceholders for default-aligned columns so later center/right settings retained their positions. Slack's currentchat.postMessagevalidation rejects those entries withinvalid_blocksandmust provide an objectat the affectedcolumn_settingsJSON pointer.User impact
Mixed-alignment Markdown tables can now be posted as native Slack table blocks instead of failing at delivery time. Tables that use only default left alignment retain the existing payload shape.
Verification
scripts/run_tests.sh tests/gateway/test_slack_block_kit.py tests/gateway/test_slack_block_kit_adapter.py -q