fix(desktop): dedupe aliased profile databases - #68303
Open
deniqlab wants to merge 1 commit into
Open
Conversation
Collaborator
Related to #50086: both dedupe aliased physical state.db targets. This PR additionally applies the protection to the sidebar endpoint, so these are overlapping alternatives rather than a duplicate relationship. |
Contributor
|
Thanks for covering both aggregate session paths. The aliased- Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Deduplicate profile targets by physical state.db before aggregating /api/profiles/sessions and /api/profiles/sessions/sidebar\n- Preserve first-seen ownership tagging and keep distinct profile databases untouched\n- Add regressions for aliased and distinct profile databases\n\n## Verification\n- python3.11 -m pytest tests/hermes_cli/test_web_server.py -k 'profiles_sessions_dedupes or profiles_sessions_keeps_distinct_profile_databases' -q\n- python3.11 -m pytest tests/hermes_cli/test_web_server.py -q\n- python3.11 -m compileall hermes_cli/web_server.py tests/hermes_cli/test_web_server.py\n- git diff --check\n\nCloses #68299