Skip to content

fix(nix): include apps/shared as tui dep - #68109

Merged
ethernet8023 merged 1 commit into
mainfrom
ethie-nix-fix
Jul 20, 2026
Merged

fix(nix): include apps/shared as tui dep#68109
ethernet8023 merged 1 commit into
mainfrom
ethie-nix-fix

Conversation

@ethernet8023

Copy link
Copy Markdown
Collaborator

What does this PR do?

#61067 added a @hermes/shared dep for ui-tui. added it to the nix deps to fix builds

Related Issue

Fixes nix builds

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • added apps/shared to nix/tui.nix

How to Test

  1. run nix build .#

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

#61067
added a @hermes/shared dep for `ui-tui`. added it to the nix deps to fix
builds
@ethernet8023
ethernet8023 enabled auto-merge (squash) July 20, 2026 15:23
@ethernet8023
ethernet8023 disabled auto-merge July 20, 2026 15:23
@ethernet8023
ethernet8023 merged commit 1705a44 into main Jul 20, 2026
2 checks passed
@ethernet8023
ethernet8023 deleted the ethie-nix-fix branch July 20, 2026 15:23
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/tui Terminal UI (ui-tui/ + tui_gateway/) area/nix Nix flake, NixOS module, container packaging duplicate This issue or pull request already exists labels Jul 20, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #67082: both add apps/shared to the Nix TUI npm source closure for the same workspace dependency.

randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
NousResearch#61067
added a @hermes/shared dep for `ui-tui`. added it to the nix deps to fix
builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nix Nix flake, NixOS module, container packaging comp/tui Terminal UI (ui-tui/ + tui_gateway/) duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants