Skip to content

fix: pass explicit basename to send_document to prevent silent delivery failure #68107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rkfshakti wants to merge 1 commit into from
Closed

fix: pass explicit basename to send_document to prevent silent delivery failure #68107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions tools/send_message_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,6 +1302,7 @@ async def _send_telegram(token, chat_id, message, media_files=None, thread_id=No
"Telegram caption-fallback send failed for missing media: %s",
_sanitize_error_text(_cap_err),
)
warnings.append(_sanitize_error_text(_cap_err))
continue

ext = os.path.splitext(media_path)[1].lower()
Expand Down Expand Up @@ -1342,7 +1343,7 @@ async def _send_telegram(token, chat_id, message, media_files=None, thread_id=No
)
else:
last_msg = await bot.send_document(
chat_id=int_chat_id, document=f, **media_kwargs
chat_id=int_chat_id, document=f, filename=os.path.basename(media_path), **media_kwargs
)
except Exception as media_err:
if _is_telegram_thread_not_found(media_err) and media_kwargs.get("message_thread_id"):
Expand Down Expand Up @@ -1373,7 +1374,7 @@ async def _send_telegram(token, chat_id, message, media_files=None, thread_id=No
)
else:
last_msg = await bot.send_document(
chat_id=int_chat_id, document=f, **media_kwargs
chat_id=int_chat_id, document=f, filename=os.path.basename(media_path), **media_kwargs
)
elif media_kwargs.get("parse_mode") and (
"parse" in str(media_err).lower()
Expand Down Expand Up @@ -1402,9 +1403,17 @@ async def _send_telegram(token, chat_id, message, media_files=None, thread_id=No
last_msg = await bot.send_video(
chat_id=int_chat_id, video=f, **media_kwargs
)
elif ext in _VOICE_EXTS and is_voice:
last_msg = await bot.send_voice(
chat_id=int_chat_id, voice=f, **media_kwargs
)
elif ext in _TELEGRAM_SEND_AUDIO_EXTS:
last_msg = await bot.send_audio(
chat_id=int_chat_id, audio=f, **media_kwargs
)
else:
last_msg = await bot.send_document(
chat_id=int_chat_id, document=f, **media_kwargs
chat_id=int_chat_id, document=f, filename=os.path.basename(media_path), **media_kwargs
)
else:
raise
Expand Down