feat(delegation): add opt-in context projection - #67929
Open
HEROISM-WQL wants to merge 5 commits into
Open
Conversation
Collaborator
teknium1
reviewed
Jul 30, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the carefully bounded, default-off implementation. The current main implementation still intentionally gives delegated children a fresh conversation and only explicit context (tools/delegate_tool.py:11, tools/delegate_tool.py:1317), so this remains a design decision rather than a duplicate fix.
Problems
- The PR adds defaults in
hermes_cli/config.py, but current main movedDEFAULT_CONFIGintohermes_cli/config_defaults.py:1543in1fe06115d1. A salvage needs to port those defaults to the canonical block. tests/tools/test_delegate_context.py:207asserts the complete generated child prompt. Please test projection invariants instead of pinning unrelated instruction wording.
Suggested changes
- Rebase the config portion onto the current
config_defaults.pylayout and cover the active config-loading path. - Keep tests focused on explicit-mode isolation, role filtering, bounded deterministic projection, and task placement.
This is an automated hermes-sweeper review.
|
|
||
|
|
||
| def test_default_config_and_child_prompt_are_byte_stable() -> None: | ||
| from hermes_cli.config import DEFAULT_CONFIG |
Contributor
There was a problem hiding this comment.
This test snapshots the entire child prompt, so unrelated valid edits to the standing child instructions will fail it. Please replace the exact-string assertion with focused behavior contracts for default-mode isolation and the relevant task/context ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety and compatibility
Testing
pytest tests/tools/test_delegate_context.py tests/tools/test_delegate.py tests/run_agent/test_run_agent.py -qruff checkon all changed Python and test filesNotes
The implementation is opt-in and introduces no new always-on core tool schema.