fix(tui): include apps/shared in npm build source for @hermes/shared workspace dependency - #67885
Closed
ryjen wants to merge 3 commits into
Closed
fix(tui): include apps/shared in npm build source for @hermes/shared workspace dependency#67885ryjen wants to merge 3 commits into
ryjen wants to merge 3 commits into
Conversation
…workspace dependency The TUI imports from @hermes/shared/charge-settlement and other shared modules, but mkNpmPassthru only included 'ui-tui' in the build source. This meant apps/shared/package.json was present (for npm workspace resolution) but apps/shared/src/ was not — so the actual TypeScript source files like charge-settlement.ts were missing at build time.
fix(tui): include apps/shared in npm build source
alt-glitch
added
type/bug
Collaborator
Duplicate of #67082: the live patch is byte-identical and makes the same |
Contributor
|
Closing as duplicate |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The TUI build (
nix/tui.nix) only passesdirs = [ "ui-tui" ]tomkNpmPassthru. Whileapps/shared/package.jsonis included for npm workspace resolution, theapps/shared/src/directory (with the actual TypeScript source files) is not — causing esbuild to fail resolving@hermes/shared/charge-settlement.Adds
"apps/shared"to the dirs list, matching the existing pattern used byapps/desktop(dirs = [ "apps/desktop" "apps/shared" ]).Related Issue
Fixes #67056
Fixes #67079
Type of Change
Changes Made
nix/tui.nix:4— add"apps/shared"tomkNpmPassthrudirsHow to Test
nix build .#tui— previously failed withERROR: Could not resolve "@hermes/shared/charge-settlement", now succeedsnix build .#packages.x86_64-linux.default— full hermes-agent package builds correctlyChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A