fix(webui): show active fallback model - #67763
Conversation
|
Thanks for narrowing the runtime-model badge work to the PTY event path. The current-main premise is confirmed: Problems
Suggested changes
Automated hermes-sweeper review. |
SummaryTwo PRs address #54509. #54895 exposes fallback identity and renders an indicator but consumes the independent sidecar session rather than the response-generating PTY path, while #67763 carries live PTY runtime identity to the sidebar, preserves compute-host metadata, and resets stale fallback state before the next primary turn. Related pull requests
Duplicates#54895 and #67763 substantially overlap on fallback metadata and the WebUI badge, but #67763 is the focused replacement that corrects #54895's sidecar-versus-PTY data path; treat closed #54895 as superseded by #67763. Suggested consolidationKeep #67763 open with a salvage path: retain its focused PTY session.info contract, runtime-model selector, compute-host mirror, reset behavior, and newly added live-turn regression while reconciling the branch with current tui_gateway/server.py. Keep #54895 closed as the broader superseded duplicate because its relevant UI approach reads the wrong session and is mixed with unrelated changes. Complex graphflowchart LR
classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
classDef best stroke-width:3px,stroke:#b45309
classDef target stroke-width:3px,stroke:#4338ca
I54509(["issue #54509 (open)"])
subgraph Dup54895 ["PRs duplicating each other"]
P54895["PR #54895 (closed)"]
P67763["PR #67763 (open)"]
end
P67763 -->|best fix| I54509
class I54509 open
class P54895 closed
class P67763 open
class P67763 best
class P67763 target
click I54509 "https://github.com/NousResearch/hermes-agent/issues/54509"
click P54895 "https://github.com/NousResearch/hermes-agent/pull/54895"
click P67763 "https://github.com/NousResearch/hermes-agent/pull/67763"
Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label). Cross-PR triage: Reviewed 2 pull requests and 1 issue in this complex. Each diff was read against this issue; Assessment working set: 86 kB of PR diffs, 6 kB of issue/PR text, 4 kB of discussion (8 comments), 3 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch. |
Summary
session.infoeventsconfig.yamlfallbackbadge with the originating primary model in its tooltipCloses #54509
Verification
python3 -m pytest tests/ -o 'addopts=' -q\u2014 377 passed\n-npm run test(web) \u2014 101 passed\n-npm run typecheck(web)\n-npm run lint(web; existing warnings only, exit 0)\n-NODE_OPTIONS=--max-old-space-size=4096 npm run build(web)