Skip to content

Fix tests/gateway/test_shutdown_forensics.py on macOS (1 failing test) #67708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henrynguyeninfo1 wants to merge 1 commit into from
Closed

Fix tests/gateway/test_shutdown_forensics.py on macOS (1 failing test) #67708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion tests/gateway/test_shutdown_forensics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,23 @@ def test_context_as_json_handles_unserialisable_values(self):

class TestSpawnAsyncDiagnostic:
@pytest.mark.skipif(sys.platform == "win32", reason="POSIX-only diagnostic")
def test_spawns_subprocess_and_writes_output(self, tmp_path):
def test_spawns_subprocess_and_writes_output(self, tmp_path, monkeypatch):
log_path = tmp_path / "diag.log"
real_popen = sf.subprocess.Popen

def popen_without_timeout(command, **kwargs):
assert command[:2] == ["timeout", "3"]
timeout_shim = (
"import subprocess, sys; "
"result = subprocess.run(sys.argv[2:], timeout=float(sys.argv[1])); "
"raise SystemExit(result.returncode)"
)
return real_popen(
[sys.executable, "-c", timeout_shim, command[1], *command[2:]],
**kwargs,
)

monkeypatch.setattr(sf.subprocess, "Popen", popen_without_timeout)

@teknium1 teknium1 Jul 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces the Popen call being tested and strips the timeout executable from its command. Production still invokes ["timeout", ...] in gateway/shutdown_forensics.py:257-264, so the test passes without exercising the macOS failure. Please test the real launcher alongside a production portability fix instead.

pid = sf.spawn_async_diagnostic(log_path, "SIGTERM", timeout_seconds=3.0)
assert pid is not None and pid > 0

Expand Down