fix(cli): Ctrl+B voice hotkey disarms continuous during STT/agent

[webtecnica]

Summary

Fixes #67545: In CLI continuous voice mode, pressing Ctrl+B (the record hotkey) during STT processing or while the agent is running was a silent no-op — it didn't disarm continuous mode, so the loop auto-restarted recording after the turn.

Root Cause

In handle_voice_record in cli.py, the non-recording branch (else) had three early-return guards (_agent_running, interactive prompts, _voice_processing) that returned without clearing _voice_continuous. The fourth path (default) would arm continuous and start a new recording. There was no path to disarm continuous without being in the recording state.

Fix

Added a check at the top of the non-recording branch: if _voice_continuous is already True, disarm it immediately and return. This makes the hotkey a proper toggle:

• Press while recording → stop + disarm (existing behavior)
• Press while continuous armed but not recording (STT/agent/processing) → disarm (NEW)
• Press while continuous not armed → arm + start recording (existing behavior)

Changes

• cli.py: ~12 lines added to handle_voice_record — disarm check before the existing guards

Testing

• All 84 existing voice CLI integration tests pass (tests/tools/test_voice_cli_integration.py)
• The fix is purely controlled by the _voice_continuous flag — no STT/TTS provider changes

[teknium1]

Thanks for the focused CLI fix. Current main confirms the reported control-flow gap: cli.py:14329-14338 returns for agent-running and STT-processing states without clearing _voice_continuous, while cli.py:15570-15580 restarts recording when that flag remains set. The proposed pre-guard disarm directly addresses those paths.

Problems

• Please add a behavioral regression test. tests/tools/test_voice_cli_integration.py:711-798 checks handler source structure but does not invoke handle_voice_record for _voice_continuous=True combined with _voice_processing or _agent_running.

Suggested changes

• Exercise the registered hotkey binding for both blocked non-recording states and assert it clears _voice_continuous without scheduling recording.

Automated hermes-sweeper review.

[alt-glitch]

This was generated by AI during triage.

Related to #67550 and #67569. This version disarms continuous mode for every armed non-recording hotkey path, while the siblings scope the change to specific busy/STT paths.

[teknium1]

The record-hotkey/continuous-mode fix landed in #73520 via @kyssta-exe's #67550, submitted 67 minutes earlier. Thanks for independently finding the same bug!

(Landed via #73520, merge e04c2a9ebd.) Closing.